From b272a5c6645e883f359a9f090766c7fcaa577626 Mon Sep 17 00:00:00 2001 From: Julie Pichon Date: Tue, 3 Jan 2017 12:17:12 +0000 Subject: [PATCH] Deprecate legacy 'baremetal' commands The new node management commands added during Newton as part of the Mistral migration/API redesign should be used instead. For additional background information, the thread at [1] is a good reference. Closes-Bug: #1649541 [1] http://lists.openstack.org/pipermail/openstack-dev/2016-May/095456.html Depends-On: I7f51190925f7ac1bfa9b122d3b746f2fd6858076 Change-Id: I5997905834f02d47811d28e337d6b2b4f85a75b7 --- tripleoclient/v1/baremetal.py | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tripleoclient/v1/baremetal.py b/tripleoclient/v1/baremetal.py index d39c02625..38cf7b742 100644 --- a/tripleoclient/v1/baremetal.py +++ b/tripleoclient/v1/baremetal.py @@ -114,7 +114,10 @@ class ValidateInstackEnv(command.Command): class ImportBaremetal(command.Command): - """Import baremetal nodes from a JSON, YAML or CSV file""" + """Import baremetal nodes from a JSON, YAML or CSV file (DEPRECATED). + + Please use 'openstack overcloud node import' instead. + """ log = logging.getLogger(__name__ + ".ImportBaremetal") @@ -155,6 +158,8 @@ class ImportBaremetal(command.Command): def take_action(self, parsed_args): self.log.debug("take_action(%s)" % parsed_args) + self.log.warning('This command is deprecated. Please use "openstack ' + 'overcloud node import" to register nodes instead.') file_type = None if parsed_args.json: @@ -193,9 +198,10 @@ class ImportBaremetal(command.Command): class StartBaremetalIntrospectionBulk(command.Command): - """Start bulk introspection on all baremetal nodes (Deprecated). + """Start bulk introspection on all baremetal nodes (DEPRECATED). - Please use 'openstack overcloud node introspect' instead. + Please use 'openstack overcloud node introspect' instead. The nodes + should be in 'manageable' state before running the command. """ log = logging.getLogger(__name__ + ".StartBaremetalIntrospectionBulk") @@ -205,7 +211,7 @@ class StartBaremetalIntrospectionBulk(command.Command): self.log.debug("take_action(%s)" % parsed_args) self.log.warning('This command is deprecated. Please use "openstack ' 'overcloud node introspect" to introspect manageable ' - 'nodes instead.\n') + 'nodes instead.') queue_name = str(uuid.uuid4()) clients = self.app.client_manager @@ -348,7 +354,10 @@ class ConfigureReadyState(command.Command): class ConfigureBaremetalBoot(command.Command): - """Configure baremetal boot for all nodes""" + """Configure baremetal boot for all nodes (DEPRECATED). + + Please use 'openstack overcloud node configure' instead. + """ log = logging.getLogger(__name__ + ".ConfigureBaremetalBoot") loops = 12 @@ -382,6 +391,9 @@ class ConfigureBaremetalBoot(command.Command): def take_action(self, parsed_args): self.log.debug("take_action(%s)" % parsed_args) + self.log.warning('This command is deprecated. Please use "openstack ' + 'overcloud node configure" to configure manageable ' + 'nodes instead.') queue_name = str(uuid.uuid4()) bm_client = self.app.client_manager.baremetal