openstack/python-tripleoclient
Code Issues Proposed changes

update output path cli switch

Browse Source 
The output cli switch was being ignored, this change will ensure that if
a user provides an output path the export function will operatate as
expected.

Change-Id: If53fa783c95d9d1031d04763f85278bea7e44b30
Signed-off-by: Kevin Carter <kecarter@redhat.com>
This commit is contained in:
Kevin Carter 2022-05-17 15:38:39 -05:00
parent 8edbcca6bf
commit b56a6035fe
No known key found for this signature in database
GPG Key ID: 5045BC941175BDF5
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tripleoclient/v1/overcloud_export.py
View File

@ -69,9 +69,6 @@ class ExportOvercloud(command.Command):
self.log.debug("take_action(%s)" % parsed_args)
stack = parsed_args.stack
output_file = parsed_args.output_file or \
'%s-export.yaml' % stack
self.log.info('Running at %s with parameters %s',
self.now,
parsed_args)
@ -89,9 +86,17 @@ class ExportOvercloud(command.Command):
else:
config_download_dir = parsed_args.config_download_dir
export_file_path = os.path.join(
output_file = parsed_args.output_file or os.path.join(
working_dir,
'{}-export.yaml'.format(parsed_args.stack))
'{}-export.yaml'.format(
parsed_args.stack
)
)
export_file_path = os.path.abspath(
os.path.expanduser(
output_file
)
)
if (os.path.exists(export_file_path) and
not parsed_args.force_overwrite):
raise Exception(
@ -104,4 +109,4 @@ class ExportOvercloud(command.Command):
with open(export_file_path, 'w') as f:
yaml.safe_dump(data, f, default_flow_style=False)
print("Stack information exported to %s." % output_file)
print("Stack information exported to %s." % export_file_path)