From ceb54aad777db34493413714cd4a4d33483b4c4e Mon Sep 17 00:00:00 2001 From: Lennart Regebro Date: Fri, 11 Dec 2015 14:28:01 +0100 Subject: [PATCH] Adding a test to exercise the command Change-Id: Ia0fb62837c813a353c1d40eb8de2c763738caad8 --- .../test_overcloud_netenv_validate.py | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py b/tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py index e96b01427..5ac43c462 100644 --- a/tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py +++ b/tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py @@ -22,6 +22,14 @@ from tripleoclient.tests.v1.overcloud_netenv_validate import fakes from tripleoclient.v1 import overcloud_netenv_validate +EMPTY_NETENV = """resource_registry: + OS::TripleO::BlockStorage::Net::SoftwareConfig: /tmp/foo + +parameter_defaults: + NeutronExternalNetworkBridge: "''" +""" + + class TestValidateOvercloudNetenv(fakes.TestValidateOvercloudNetenv): def setUp(self): @@ -248,3 +256,18 @@ class TestValidateOvercloudNetenv(fakes.TestValidateOvercloudNetenv): 'OS::TripleO::Controller::Net::SoftwareConfig', tmp) os.unlink(tmp) self.assertEqual(1, self.cmd.error_count) + + def test_command(self): + """Testing the command with a minimal file that will fail""" + with tempfile.NamedTemporaryFile('wt') as net_file: + net_file.write(EMPTY_NETENV) + net_file.flush() + + arglist = ['--file', net_file.name] + verifylist = [ + ('netenv', net_file.name), + ] + + parsed_args = self.check_parser(self.cmd, arglist, verifylist) + # Validating a minimal file shouldn't raise errors. + self.cmd.take_action(parsed_args)