openstack/python-tripleoclient
Code Issues Proposed changes

Fix network environment validation

Browse Source 
Network environment validation fails when accessing value
with the key 'os_net_config' from the nic-config files.
Fix the dictionary keys needed to fetch the network
config from nic_data.

Signed-off-by: Yadnesh Kulkarni <ykulkarn@redhat.com>
Change-Id: I2ec628dd9c9cf14c0cd9d8ba30f53ac18efe115f
This commit is contained in:
Yadnesh Kulkarni
2021-04-26 21:29:02 +05:30
committed by James Slagle
parent 17ee9ea448
commit d2eb988973
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py
View File

@@ -46,7 +46,9 @@ class TestValidateOvercloudNetenv(fakes.TestValidateOvercloudNetenv):
'OsNetConfigImpl': {
'properties': {
'config': {
'os_net_config': {
'str_replace': {
'params': {
'$network_config': {
'network_config': bridges,
}
}
@@ -54,6 +56,8 @@ class TestValidateOvercloudNetenv(fakes.TestValidateOvercloudNetenv):
}
}
}
}
}
tmp = tempfile.NamedTemporaryFile(mode='w', delete=False)
yaml.dump(nic_config, tmp)
tmp.close()

2
tripleoclient/v1/overcloud_netenv_validate.py
View File

@@ -175,7 +175,7 @@ class ValidateOvercloudNetenv(command.Command):
# no bonds.
for item in nic_data['resources']:
bridges = nic_data['resources'][item]['properties']['config'][
'os_net_config']['network_config']
'str_replace']['params']['$network_config']['network_config']
for bridge in bridges:
if bridge['type'] == 'ovs_bridge':
bond_count = 0