From daf94b006f29182008aad1d1d8c9194e5d3b07e2 Mon Sep 17 00:00:00 2001 From: Steve Baker Date: Tue, 15 May 2018 09:21:11 +1200 Subject: [PATCH] Remove unused option enable_container_images_build This option was added in change I5cf5798cd084d99a3c892daab6db444d1e608beb but was never actually wired in to do anything. Since we now have such comprehensive image build pipelines, I think it is better to removed this unused option rather than wire it in. Change-Id: I20f67d8b1bbeb8b768777a41b5d33c819192ea2d --- tripleoclient/config/undercloud.py | 6 ------ tripleoclient/tests/config/test_config_undercloud.py | 2 -- 2 files changed, 8 deletions(-) diff --git a/tripleoclient/config/undercloud.py b/tripleoclient/config/undercloud.py index 3601aefe8..bfe19ca45 100644 --- a/tripleoclient/config/undercloud.py +++ b/tripleoclient/config/undercloud.py @@ -248,12 +248,6 @@ class UndercloudConfig(StandaloneConfig): 'install. This is a no-op for containerized ' 'undercloud.') ), - cfg.BoolOpt('enable_container_images_build', - default=True, - help=_( - 'Whether to enable docker container images to be ' - 'build on the undercloud.') - ), cfg.StrOpt('ipa_otp', default='', help=_( diff --git a/tripleoclient/tests/config/test_config_undercloud.py b/tripleoclient/tests/config/test_config_undercloud.py index 2d38e3268..18dff0595 100644 --- a/tripleoclient/tests/config/test_config_undercloud.py +++ b/tripleoclient/tests/config/test_config_undercloud.py @@ -34,7 +34,6 @@ class TestUndercloudConfig(base.TestCase): 'discovery_default_driver', 'docker_insecure_registries', 'docker_registry_mirror', - 'enable_container_images_build', 'enable_node_discovery', 'enable_routed_networks', 'enable_swift_encryption', @@ -83,7 +82,6 @@ class TestUndercloudConfig(base.TestCase): 'docker_insecure_registries', 'docker_registry_mirror', 'enable_cinder', - 'enable_container_images_build', 'enable_ironic', 'enable_ironic_inspector', 'enable_mistral',