openstack
/
python-tripleoclient
Code Issues Proposed changes

Add test for the function check_deprecated_parameters. 

Add test for the function check_deprecated_parameters in workflows
parameters file. Test the unused_params and invalid_role_specific_params
parts.

Change-Id: I052d9958f52479e196d5e5dd4531f3971d7c0eb8
Closes-Bug: #1838923
Depends-On: https://review.opendev.org/#/c/674570/
This commit is contained in:
Natal Ngétal 2019-08-05 07:34:42 +02:00
parent 8ce8b93cbe
commit ddb9970aef
1 changed files with 86 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
tripleoclient/tests/workflows/test_parameters.py
View File

@ -194,6 +194,92 @@ class TestParameterWorkflows(utils.TestCommand):
workflow_input={'container': 'container-name'})
self.assertFalse(mock_log.log.warning.called)
def test_check_deprecated_multiple_parameters(self):
msg = ("WARNING: Following parameter(s) are deprecated and still "
"defined. Deprecated parameters will be removed soon!"
" TestParameter1, TestParameter2")
deprecated_params = [{'parameter': 'TestParameter1',
'deprecated': True,
'user_defined': True},
{'parameter': 'TestParameter2',
'deprecated': True,
'user_defined': True}]
self.websocket.wait_for_messages.return_value = iter([{
"execution_id": "IDID",
"status": "SUCCESS",
"deprecated": deprecated_params
}])
with mock.patch('tripleoclient.workflows.parameters.LOG') as mock_log:
parameters.check_deprecated_parameters(
self.app.client_manager,
container='container-name')
self.workflow.executions.create.assert_called_once_with(
'tripleo.plan_management.v1.get_deprecated_parameters',
workflow_input={'container': 'container-name'})
mock_log.warning.assert_called_once_with(msg)
def test_check_unused_parameters(self):
msg = ("WARNING: Following parameter(s) are defined but not currently"
" used in the deployment plan. These parameters may be valid"
" but not in use due to the service or deployment"
" configuration. TestParameter1")
unused_params = ['TestParameter1']
self.websocket.wait_for_messages.return_value = iter([{
"execution_id": "IDID",
"status": "SUCCESS",
"unused": unused_params
}])
with mock.patch('tripleoclient.workflows.parameters.LOG') as mock_log:
parameters.check_deprecated_parameters(
self.app.client_manager,
container='container-name')
self.workflow.executions.create.assert_called_once_with(
'tripleo.plan_management.v1.get_deprecated_parameters',
workflow_input={'container': 'container-name'})
mock_log.warning.assert_called_once_with(msg)
def test_check_unused_multiple_parameters(self):
msg = ("WARNING: Following parameter(s) are defined but not currently"
" used in the deployment plan. These parameters may be valid"
" but not in use due to the service or deployment"
" configuration. TestParameter1, TestParameter2")
unused_params = ['TestParameter1', 'TestParameter2']
self.websocket.wait_for_messages.return_value = iter([{
"execution_id": "IDID",
"status": "SUCCESS",
"unused": unused_params
}])
with mock.patch('tripleoclient.workflows.parameters.LOG') as mock_log:
parameters.check_deprecated_parameters(
self.app.client_manager,
container='container-name')
self.workflow.executions.create.assert_called_once_with(
'tripleo.plan_management.v1.get_deprecated_parameters',
workflow_input={'container': 'container-name'})
mock_log.warning.assert_called_once_with(msg)
def test_check_invalid_role_specific_parameters(self):
msg = ("WARNING: Following parameter(s) are not supported as"
" role-specific inputs. TestParameter1")
invalid_role_specific_params = ['TestParameter1']
self.websocket.wait_for_messages.return_value = iter([{
"execution_id": "IDID",
"status": "SUCCESS",
"invalid_role_specific": invalid_role_specific_params
}])
with mock.patch('tripleoclient.workflows.parameters.LOG') as mock_log:
parameters.check_deprecated_parameters(
self.app.client_manager,
container='container-name')
self.workflow.executions.create.assert_called_once_with(
'tripleo.plan_management.v1.get_deprecated_parameters',
workflow_input={'container': 'container-name'})
mock_log.warning.assert_called_once_with(msg)
def test_generate_fencing_parameters(self):
self.websocket.wait_for_messages.return_value = iter([{
"execution_id": "IDID",