openstack/python-tripleoclient
Code Issues Proposed changes

Dedup host entries in the exported data for stacks

Browse Source 
Do not add extra host entries for VIPs for stacks deployed off the
exported data, since it already contains those entries

This is done by setting AddVipsToEtcHosts to False.
Then a stack is deployed, no more VIPs will be added into /etc/hosts
of the targeted hosts.

Change-Id: Iba03aed76fab1977e2b51ef69e8e08a493152ed6
Closes-bug: #1911792
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This commit is contained in:
Bogdan Dobrelya 2021-01-14 18:36:09 +01:00
parent 34dccbccc2
commit e3c118756f
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tripleoclient/tests/v1/test_overcloud_export.py
View File

@ -59,7 +59,8 @@ class TestOvercloudExport(utils.TestCommand):
False,
path)
self.assertEqual(
{'parameter_defaults': {'key': 'value',
{'parameter_defaults': {'AddVipsToEtcHosts': False,
'key': 'value',
'key0': 'value0'}},
mock_safe_dump.call_args[0][0])

3
tripleoclient/v1/overcloud_export.py
View File

@ -89,6 +89,9 @@ class ExportOvercloud(command.Command):
not parsed_args.no_password_excludes)
data.update(export.export_stack(
clients.orchestration, stack, False, config_download_dir))
# do not add extra host entries for VIPs for stacks deployed off that
# exported data, since it already contains those entries
data.update({'AddVipsToEtcHosts': False})
data = dict(parameter_defaults=data)
# write the exported data