openstack/python-tripleoclient
Code Issues Proposed changes

Remove the disable_upgrade_deployment flag validation

Browse Source 
This flag is no longer used or expected in the roles_data so
we should remove the validation which is now confusing at best.

Change-Id: I4227f82168271089ae32cbb1f318d4a84e278cc7
Depends-On: Ib340376ee80ea42a732a51d0c195b048ca0440ac
This commit is contained in:
mandreou 2018-03-29 15:25:35 +03:00
parent 62a7bb1df1
commit fecf526128
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tripleoclient/v1/overcloud_deploy.py
View File

@ -524,25 +524,6 @@ class DeployOvercloud(command.Command):
"Error: The --deployed-server cannot be used without "
"the --disable-validations")
# Check if disable_upgrade_deployment is set once
self.log.debug("Checking that the disable_upgrade_deployment flag "
"is set at least once in the roles file")
if parsed_args.roles_file:
roles_data = yaml.safe_load(open(parsed_args.roles_file).read())
disable_upgrade_deployment_set = False
for r in roles_data:
if r.get("disable_upgrade_deployment"):
disable_upgrade_deployment_set = True
break
if not disable_upgrade_deployment_set:
self.log.warning(
"The disable_upgrade_deployment flag is not set in the "
"roles file. This flag is expected when you have a "
"nova-compute or swift-storage role. Please check the "
"contents of the roles file: %s" % roles_data)
if parsed_args.validation_warnings_fatal:
raise exceptions.InvalidConfiguration()
if parsed_args.environment_directories:
self._validate_args_environment_directory(
parsed_args.environment_directories)