openstack
/
python-tripleoclient
Code Issues Proposed changes

[TRAIN-Only] Warn about docker if python3 

We don't want docker to be used if running under python3, so let's throw
a warning. Since train will support centos7 still, we need to not have
this be a default.

Change-Id: Ia7fa0b84e628afd51c75d9c09f9939cbb33799bc
This commit is contained in:
Alex Schultz 2021-02-10 11:37:52 -07:00
parent 12f6371df7
commit ff641043a8
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tripleoclient/utils.py
View File

@ -2011,12 +2011,19 @@ def check_file_for_enabled_service(env_file):
with open(env_file, "r") as f:
content = yaml.safe_load(f)
deprecated_services_enabled = []
for service in constants.DEPRECATED_SERVICES.keys():
deprecated_services = constants.DEPRECATED_SERVICES
python_version = sys.version_info[0]
# handle train special case of docker still being supported on centos7
if python_version == 3:
deprecated_services.update({
"OS::TripleO::Services::Docker": "Replaced with Podman."})
for service in deprecated_services.keys():
try:
if content["resource_registry"][service] != "OS::Heat::None":
LOG.warning("service " + service + " is enabled in "
+ str(env_file) + ". " +
constants.DEPRECATED_SERVICES[service])
deprecated_services[service])
deprecated_services_enabled.append(service)
except (KeyError, TypeError):
# ignore if content["resource_registry"] is empty