- fixes two issues identified by newer flake8
- upgrades flake8 and keeps it pinned
- removes hacking as this is no longer needed, as pre-commit does
its own pinning.
- enables us to easily add other linters, pylint would come in
follow-up
Change-Id: If26234fad0cd982bd7d3dc23c42021b357c6bde9
Related-Bug: #1910543
The validator run command will now raise a CommandError exception if one
or more validations have failed.
This patch is also aligning the result table to left in order to be
compliant with other table output.
Change-Id: I265b77de4b8f9b611f6bc908e90d8f69a26439ab
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Kernel and ramdisk images are found nonexistent when "file://"
is prepended to the image path, so replace it with empty
string only when checking the existence of the image
Closes-Bug: #1896262
Signed-off-by: Yadnesh Kulkarni <ykulkarn@redhat.com>
Change-Id: I641dd1c3426048f5aace0ac695eb8cef7126f8c2
We can set the heat parameters in the client itslef and there
would be no need to update plan environment and can get rid of
the ansible tasks for those.
Same applies for RootStackName.
Also, removes multiple redundant calls to _update_parameters()
Change-Id: I54762eb6881113c67744207f53fd92cf003e0559
All the PrettyTables are aligned to left and this patch standardizes all
the tables.
Change-Id: Ide062e65b0a76078b5d3ce55a60df3cb5be34a0e
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This file, and its tests, are not useful for tripleo so we're
removing because they're now becoming problematic.
Change-Id: I656105826e5fa85ffaf077bdc831fa5800ad493c
Signed-off-by: Kevin Carter <kecarter@redhat.com>
This patch use deployment.get_deployment_status to check
if the stack and the plan exist on the env if a --plan
option has been passed.
Change-Id: I23e2bba9fc9e9b0574786d8594d89102759fad64
We've used this for many releases now and we're unlikely to change it
now. Let's drop the experimental warning.
Change-Id: Ib4c7520cc4dc12ca5967d638a15d74b14be5ca62
Fix debug logging for buildah bud
Pass the application debug option to the called build process as well
Co-authored-by: Bogdan Dobrelya <bdobreli@redhat.com>
Change-Id: Ic671e38fd4f07828174e908a28f564cacf8ded97
Currently it catches SystemError and log error message
but do not fail, raise SystemError so it fails too.
Closes-Bug: #1905348
Change-Id: I2e823c58779dba529a58aff5e0e1c0c880c267aa
Since we are using mistral to get the list of the plan
in TripleO, we require authentication for the clients
otherwise the validation Run won't work due to unable
to get mistral context.
This patch handle the authentication if provided by the user and
environment, if no authentifcation, since we cant generate dynamic
inventory, it checks if a static is passed with the CLI, if not it
raised an exception.
If authentication is provided and succeed, then tripleoclient can
safely call the plan_management to check and ensure if the plan is
present.
Change-Id: I5a702a84ca0e1942f2e1636d31acc391f689a8ad
Currently, when building container images, we are overriding the ubi
image repos with the repos configured in the host. Effectively, this is
removing ubi repo config from the image build environment which most of
the times is not a problem as centos is on sync with ubi, but in some
cases as after RHEL 8.3 release, ubi is ahead of CentOS and need
packages from the ubi repo itself.
This patch is bind mounting the repos config from build host in
distro.repos.d instead of yum.repos.d. In that way, both the repos
configured by default in the image (ubi repos) and the ones in the host
are available.
Depends-On: https://review.opendev.org/#/c/763203
Closes-Bug: #1902846
Change-Id: I55f4b8cf2ad971e196fbd06db743d07ce3135ea8
... because these options were supposed to be removed from the deploy
command during Ussuri release[1].
[1] 200d20a71c
Change-Id: I01cd598f090568283d1684e9f5a4d741d14ef4a0
ubi-8 based jobs uses tcib method of building containers
and same method also used by content-provider jobs.
We nearly migrated to content-provider, this jobs
are no longer in use.
Change-Id: I499a1d8f985843cf11dfb3b620e119a895380fe1
Signed-off-by: Amol Kahat <amolkahat@gmail.com>
`overcloud cell export` command does not have option
to provide from where to copy export data if config-download
data is exported to custom directory.
This change add the option for `overcloud cell export` command
to provide custom directory.
Change-Id: I8e2a0922662c0a4d913469fcf2b3180d31512b0f
- Replace logging with logging from oslo_log
In order to have timestamps as well as other features this patch
replaces python logging to extended logging from oslo_log. This allows
to produce timestamps in output messages
- Replace some prints with log.info to have timing information in logs
Change-Id: I3569272795a52bb25f3de502fdfd5006ff6b8be1
Related-Bug: #1890389
When using net-config-override, objects can exist without a 'name' key.
The validation fails with KeyError: 'name'. This change only considers
objects with 'name' key present.
Change-Id: I77a30b13e4459ed3dae64a23b128433639eec5b4
Sorin Sbarnea
yatinkarel