Commit Graph

3106 Commits (04c1466c44cec7a9c20e9eef8f480875907d0e3c)

Author SHA1 Message Date
Sorin Sbarnea 04c1466c44 Enable pylint
Related-Bug: #1910543
Change-Id: I8cba98b97ebb6d18fce84c86cceb5c30b93dd194
2021-01-08 13:40:58 +00:00
Sorin Sbarnea 276bacfb92 Run flake8 using pre-commit
- fixes two issues identified by newer flake8
- upgrades flake8 and keeps it pinned
- removes hacking as this is no longer needed, as pre-commit does
  its own pinning.
- enables us to easily add other linters, pylint would come in

Change-Id: If26234fad0cd982bd7d3dc23c42021b357c6bde9
Related-Bug: #1910543
2021-01-08 13:28:45 +00:00
Zuul dc2aacaefd Merge "Overcloud image has missing kernel_id and ramdisk_id properties" 2021-01-08 11:26:56 +00:00
Zuul 2626c0e72d Merge "Set DeployIndentifier early in tripleoclient-parameters.yaml" 2021-01-08 05:34:10 +00:00
Zuul 2311479bd3 Merge "Wire up new tripleo upgrades jobs template" 2021-01-07 23:45:26 +00:00
Zuul f463fa1e47 Merge "Add --disable-container-prepare flag" 2021-01-07 00:56:54 +00:00
Gael Chamoulaud (Strider) be3f43ff81
[Validator Run] Add return code management
The validator run command will now raise a CommandError exception if one
or more validations have failed.

This patch is also aligning the result table to left in order to be
compliant with other table output.

Change-Id: I265b77de4b8f9b611f6bc908e90d8f69a26439ab
Signed-off-by: Gael Chamoulaud (Strider) <>
2021-01-05 17:31:24 +01:00
Yadnesh Kulkarni 6546970a73 Overcloud image has missing kernel_id and ramdisk_id properties
Kernel and ramdisk images are found nonexistent when "file://"
is prepended to the image path, so replace it with empty
string only when checking the existence of the image

Closes-Bug: #1896262
Signed-off-by: Yadnesh Kulkarni <>
Change-Id: I641dd1c3426048f5aace0ac695eb8cef7126f8c2
2021-01-05 21:52:45 +05:30
Marios Andreou 48bedd7603 Wire up new tripleo upgrades jobs template
The depends-on adds a new upgrade jobs template which is wired up
here. Once wired up across tripleo we can remove excess content
providers with [1].


Change-Id: I29b34ecfbbfc193a5c10c1b8a252660ebb5c4905
2021-01-05 14:14:48 +02:00
Rabi Mishra e11dcaea5d Set DeployIndentifier early in tripleoclient-parameters.yaml
We can set the heat parameters in the client itslef and there
would be no need to update plan environment and can get rid of
the ansible tasks for those.

Same applies for RootStackName.

Also, removes multiple redundant calls to _update_parameters()

Change-Id: I54762eb6881113c67744207f53fd92cf003e0559
2021-01-05 10:24:40 +05:30
Gael Chamoulaud (Strider) c6f22c1f3c [UX] Align to left the table for the validations run results
All the PrettyTables are aligned to left and this patch standardizes all
the tables.

Change-Id: Ide062e65b0a76078b5d3ce55a60df3cb5be34a0e
Signed-off-by: Gael Chamoulaud (Strider) <>
2021-01-04 14:59:10 +00:00
Zuul 44b94ee9bf Merge "Drop experimental for tripleo deploy" 2020-12-16 19:12:06 +00:00
Zuul d659a9af68 Merge "Get deployment status to check if plan and stack exists on the env" 2020-12-11 23:39:58 +00:00
Kevin Carter 136e7440a9 The lower constraint file has been removed
This file, and its tests, are not useful for tripleo so we're
removing because they're now becoming problematic.

Change-Id: I656105826e5fa85ffaf077bdc831fa5800ad493c
Signed-off-by: Kevin Carter <>
2020-12-08 10:54:59 -06:00
Zuul 7f0e03d269 Merge "Honor --debug for buildah builder" 2020-12-06 20:01:26 +00:00
Zuul 53dee001c9 Merge "Dumping task key instead of tasks from validation_output" 2020-12-04 17:18:33 +00:00
Zuul 09a54a8ee3 Merge "Add config-download-dir flag to cell export command" 2020-12-04 09:16:36 +00:00
Mathieu Bultel c9a13bed00 Get deployment status to check if plan and stack exists on the env
This patch use deployment.get_deployment_status to check
if the stack and the plan exist on the env if a  --plan
option has been passed.

Change-Id: I23e2bba9fc9e9b0574786d8594d89102759fad64
2020-12-03 20:25:39 +01:00
Zuul 10a5c9b66b Merge "Add new toggle to disable Swift" 2020-12-02 04:19:34 +00:00
Alex Schultz a6ceb26fb8 Drop experimental for tripleo deploy
We've used this for many releases now and we're unlikely to change it
now. Let's drop the experimental warning.

Change-Id: Ib4c7520cc4dc12ca5967d638a15d74b14be5ca62
2020-12-01 07:49:32 -07:00
Gael Chamoulaud (Strider) c8137f8f01
Dumping task key instead of tasks from validation_output
Change-Id: I9b5445cbccf34e31daf055d264975d0a1eba9aba
Signed-off-by: Gael Chamoulaud (Strider) <>
2020-12-01 14:27:46 +01:00
Zuul 54a6f7eaf4 Merge "Map build host repos to distro.repos.d instead of yum.repos.d" 2020-11-30 14:43:33 +00:00
Alex Schultz 501fea0dad Honor --debug for buildah builder
Fix debug logging for buildah bud
Pass the application debug option to the  called build process as well

Co-authored-by: Bogdan Dobrelya <>
Change-Id: Ic671e38fd4f07828174e908a28f564cacf8ded97
2020-11-30 10:47:18 +01:00
Zuul a73c5fe235 Merge "Provision composable networks command" 2020-11-26 21:26:15 +00:00
Zuul 83e5d6a449 Merge "Update master for stable/victoria" 2020-11-25 14:42:08 +00:00
Zuul 4321529a6a Merge "Replace deprecated UPPER_CONSTRAINTS_FILE variable" 2020-11-25 13:21:35 +00:00
Zuul 12b6271489 Merge "Remove count/flavor options from overcloud deploy" 2020-11-25 12:29:24 +00:00
yatinkarel 2c7f7d6e61 [Container build] raise Exception post logging error
Currently it catches SystemError and log error message
but do not fail, raise SystemError so it fails too.

Closes-Bug: #1905348
Change-Id: I2e823c58779dba529a58aff5e0e1c0c880c267aa
2020-11-24 08:32:34 +05:30
Harald Jensås a5314b1e9a Provision composable networks command
Command to provision (create/update) composabale networks,
segments and subnets.

Change-Id: I9736143d33c9390f764bb6eb0c92004daeb114be
2020-11-20 14:01:04 +01:00
Zuul 2fff553f7f Merge "Run validation without authentication in particular context" 2020-11-19 22:45:29 +00:00
Zuul e7ddf5d928 Merge "Extract provisioned networks from stack" 2020-11-19 11:02:43 +00:00
Mathieu Bultel ff4f4a9578 Run validation without authentication in particular context
Since we are using mistral to get the list of the plan
in TripleO, we require authentication for the clients
otherwise the validation Run won't work due to unable
to get mistral context.
This patch handle the authentication if provided by the user and
environment, if no authentifcation, since we cant generate dynamic
inventory, it checks if a static is passed with the CLI, if not it
raised an exception.

If authentication is provided and succeed, then tripleoclient can
safely call the plan_management to check and ensure if the plan is

Change-Id: I5a702a84ca0e1942f2e1636d31acc391f689a8ad
2020-11-18 15:44:11 +00:00
yatinkarel a4fdf46d83 Map build host repos to distro.repos.d instead of yum.repos.d
Currently, when building container images, we are overriding the ubi
image repos with the repos configured in the host. Effectively, this is
removing ubi repo config from the image build environment which most of
the times is not a problem as centos is on sync with ubi, but in some
cases as after RHEL 8.3 release, ubi is ahead of CentOS and need
packages from the ubi repo itself.

This patch is bind mounting the repos config from build host in
distro.repos.d instead of yum.repos.d. In that way, both the repos
configured by default in the image (ubi repos) and the ones in the host
are available.

Closes-Bug: #1902846
Change-Id: I55f4b8cf2ad971e196fbd06db743d07ce3135ea8
2020-11-18 15:36:18 +00:00
Zuul 8f62f9d844 Merge "Improve the error message about image tags" 2020-11-18 13:40:02 +00:00
Takashi Kajinami 8cc029b99c Remove count/flavor options from overcloud deploy
... because these options were supposed to be removed from the deploy
command during Ussuri release[1].

[1] 200d20a71c

Change-Id: I01cd598f090568283d1684e9f5a4d741d14ef4a0
2020-11-16 22:56:18 +09:00
Zuul d6bd04edf5 Merge "Fix preflight validation" 2020-11-13 17:00:01 +00:00
Zuul 2fe05afd42 Merge "Removed ubi-8 based jobs" 2020-11-11 14:46:01 +00:00
Amol Kahat 02593d0b47
Removed ubi-8 based jobs
ubi-8 based jobs uses tcib method of building containers
and same method also used by content-provider jobs.

We nearly migrated to content-provider, this jobs
are no longer in use.

Change-Id: I499a1d8f985843cf11dfb3b620e119a895380fe1
Signed-off-by: Amol Kahat <>
2020-11-10 09:41:17 +05:30
Zuul 8d70f39cbd Merge "Ensure build packages installed at runtime" 2020-11-06 21:01:29 +00:00
Rajesh Tailor 4e0465fef8 Add config-download-dir flag to cell export command
`overcloud cell export` command does not have option
to provide from where to copy export data if config-download
data is exported to custom directory.

This change add the option for `overcloud cell export` command
to provide custom directory.

Change-Id: I8e2a0922662c0a4d913469fcf2b3180d31512b0f
2020-11-05 10:42:50 +05:30
Harald Jensås 006b125637 Extract provisioned networks from stack
Extract networks provisioned in stack and dump
output to valid network_data.yaml format.

Change-Id: Ibae7e2f46eb2c1c20fc9c5aed95284e3a24c66ae
2020-11-04 14:24:50 +01:00
Hervé Beraud da2da07efc Replace deprecated UPPER_CONSTRAINTS_FILE variable
the new environment variable name that replaces it [1].

This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.


Change-Id: I814b6c6507116d91f4df6fa5911aab8a1b2f3911
2020-11-04 11:09:53 +01:00
Sergii Golovatiuk b139da3995 Logging refactor
- Replace logging with logging from oslo_log
  In order to have timestamps as well as other features this patch
  replaces python logging to extended logging from oslo_log. This allows
  to produce timestamps in output messages
- Replace some prints with to have timing information in logs

Change-Id: I3569272795a52bb25f3de502fdfd5006ff6b8be1
Related-Bug: #1890389
2020-11-03 15:43:26 +01:00
Zuul bec4e6fcb1 Merge "[Validator Show Run] Display simplified results by default" 2020-11-02 13:54:22 +00:00
Zuul 70c6d4e0b9 Merge "Do not require authentication for the validator CLI" 2020-11-02 12:05:39 +00:00
Zuul dd03e70804 Merge "Allow playbooks to come from a venv version" 2020-11-01 03:23:42 +00:00
Zuul 86ea24abee Merge "Remove detection of package manager for undercloud upgrade" 2020-11-01 02:10:13 +00:00
Zuul 0ff91951b4 Merge "Switch deployed-server if nova unavailable" 2020-10-31 02:30:09 +00:00
Zuul 880116e2d5 Merge "Handle root as a deployment user better" 2020-10-31 02:07:21 +00:00
Mihai Plasoianu 1362b900f9 Fix preflight validation
When using net-config-override, objects can exist without a 'name' key.
The validation fails with KeyError: 'name'. This change only considers
objects with 'name' key present.

Change-Id: I77a30b13e4459ed3dae64a23b128433639eec5b4
2020-10-30 21:33:34 +00:00