Commit Graph

103 Commits (4243df7de1310439a6ab1574929327e0cf3554bf)

Author SHA1 Message Date
matbu 10a0873770 Use Validations libs Client for main validation entry point
This patch implement validations-libs CLI in tripleo-validator
in order to converge and get only one entry point for the validations
in tripleo and Openstack.

Change-Id: I65fdbd0ffd42411196b0b3a25690670b76dda2c8
2021-05-17 22:44:09 +02:00
James Slagle 865167d255 Bump reqirements to tripleo-common>=16.0.0
Now that tripleo-common==16.0.0 is released, we can require it in
tripleoclient. The release contains
so we can remove the try/except import handling.

Change-Id: I2fcf8391636af0fc3c01988500deb769ca220f89
Signed-off-by: James Slagle <>
2021-04-29 09:22:51 -04:00
apetrich 7c927208dc Bump up the version for osc-lib as ooo-validations need it.
Change-Id: I5373624f3bac285d9c88eba3aadec7b4c657fbc0
2021-03-22 14:17:04 +01:00
Kevin Carter 7c40575d7b
Update client to create archive and use tripleo-common
The client utils will now run a new playbook to ensure that the local
archive directory is created early in the deployment process. This
change will allow us to build toward a swift-less deployment. All of
the client calls, save one, has been moved to use tripleo-common which
will assist us to better manage, and migrate from swift storage to a
local archive.

> As a product of this change all of the "webhook" calls have been
  removed. which was deprecated as part of the Zaqar and Mistral work.
  These calls were removed because several swift calls were tied into
  them, and because mistral is no longer part of the stack, and has
  been gone for a few cycles, we can safely remove these calls which
  do nothing.

Depends-On: Ibe9b2ffe94cdf493fc84366979d1d78b8528ea1b
Change-Id: I7531612a49527f8a21df415c648acb41ac7a0b10
Signed-off-by: Kevin Carter <>
2021-01-20 09:43:52 -06:00
Alex Schultz 501fea0dad Honor --debug for buildah builder
Fix debug logging for buildah bud
Pass the application debug option to the  called build process as well

Co-authored-by: Bogdan Dobrelya <>
Change-Id: Ic671e38fd4f07828174e908a28f564cacf8ded97
2020-11-30 10:47:18 +01:00
Harald Jensås 6ced9c71db ctlplane network attributes in overcloud environment
Set CtlplaneNetworkAttributes parameter in overcloud
environment. The parameter contains a map with network
and subnets data.

    dns_domain: ctlplane.localdomain.
    mtu: 1442
    name: ctlplane
    tags: ['', '']
      dns_nameservers: ['', '']
      - {'destination': '', 'nexthop': ''}
      ip_version: 4
      name: ctlplane-leaf1

Also set the CtlplaneNetworkAttributes in the undercloud environment
from the data in undercloud.conf.

Also set the CtlplaneNetworkAttributes in the standalone environment.

Change-Id: I12f1ea965d489eb36353e988cc3ec947f72a35ad
2020-09-27 19:16:20 +02:00
Jeremy Freudberg 02e851fe2b Build timeout as CLI arg for container image build
In it was suggested that the
timeout be a CLI arg. And at present the ppc64le RDO container build job
needs quite a big timeout.

Change-Id: I6bf5238864228c54c84b22b567d873cf29f0e82c
2020-09-22 09:49:50 -04:00
Rabi Mishra e4d2658dc9 Bump ansible-runner to 1.4.5
There are a few bugs with extra_vars in 1.4.4 which impacts us
at times.

Also bumps some other lower constraints broken due to migration
to ubuntu-focal.

Change-Id: I9efbc71536f0450fbee1ed87f7156f3eba501f02
2020-09-10 17:06:59 +05:30
wu.chunyang 064ce9c8fd Remove translation sections from setup.cfg
These translation sections are not needed anymore, Babel can
generate translation files without them.

Remove babel.cfg as well, this is the default role and not needed

also remove Babel from requirements[1]

Change-Id: I8a5b7c3fc87a27c774deb368b877a9697ba320f3
2020-06-15 00:15:39 +08:00
Mathieu Bultel 6dee93a9e7 Implement validations-libs framework for ALL validator commands
Implement All command with validations libs framework

Change-Id: I0443da140020540917396cdfe00da8ac29d20297
2020-06-09 19:13:47 +02:00
Emilien Macchi 185d9f8954 Bump tripleo-common
For the Container Image Build command, we need new functionalities from
the BuildahBuilder that were released after 12.4.0 tag.

This patch makes sure tripleo-common >= 12.4.0 is pulled in the Python

Change-Id: I7651144cdb7142647b1c6303c4af4ba2ca2e2c58
2020-05-27 13:49:12 -04:00
Andreas Jaeger 655e0178a1 Cleanup py27 support
Make a few cleanups:
- Remove python 2.7 stanza from
- Add requires on python >= 3.6 to setup.cfg so that pypi and pip
  know about the requirement
- Remove obsolete sections from setup.cfg:
  * Wheel is not needed for python 3 only repo
  * Some other sections are obsolete
- Update classifiers
- Update requirements, no need for python_version anymore

Change-Id: I45b5b8582b67b39823a6e21221c491842b390b96
2020-04-04 17:19:56 +02:00
Rabi Mishra 6c626e68da Bump python-openstackclient
With, we've started using
osc 5.2.0 which is not backward compatible. Let's bump the

Change-Id: Ic135ea0296a139496c9f699f5dbc5c8d3d1f0777
2020-04-02 11:48:47 +05:30
Rabi Mishra 14fb60ad68 Use tripleo_common library directly for package_update
Also bumps tripleo-common requirements/lower-constraints.

Change-Id: Ib68c6b23f41fa848d82d30dc1d04201c76b2dc97
2020-03-25 10:13:42 +05:30
Wes Hayutin 712d8d7a61 update ironclient requirements
Partial-Bug: #1862674
Change-Id: I325761643bd0c765e1759905e5cccd80dafa742f
2020-02-14 16:39:09 -07:00
Kevin Carter bcc9c66747
Replace ansible shell with python runner
This change replaces all of the ansible shell commands with the
python library, ansible-runner. This library is supported by
upstream ansible, is approved by the openstack foundation, is
supported in global requirements, and provides a better, more
programatic interface into running ansible playbooks.

All tests that interacted with the old shell commands have been
updated to now test using the library.

Change-Id: I8db50da826e2fbc074f4e7986d6fd00f6d488648
Signed-off-by: Kevin Carter <>
2019-12-17 07:35:35 -06:00
Alex Schultz 3ca472c24f Switch to use process executor
We switched the tripleo-container-image-prepare script in
tripleo-common, but a user will likely run the 'openstack tripleo
container image prepare' command. Currently it uses the default which is
the threading executor.

Poke tripleo common lower/requirements as well.

Change-Id: Ifc5b46633a1f9fc9378eaa17170f6664d566c3c4
Related-Bug: #1844446
2019-11-21 09:52:08 +01:00
Marios Andreou ec1629b7d3 Bump tripleo-common requirements.txt to fix tox docs job
We need latest tripleo-common from depends-on to fix the related

Change-Id: I3ee7b20db1dd67294b26048185df5a6c58822601
Related-Bug: 1849788
2019-10-25 14:48:10 +00:00
Gael Chamoulaud fdf79cf4f3 Run Validations with ThreadPoolExecutor
The validations are sequentially executed through ansible-playbook and
could take some time to complete. This patch adds support of running all
the validations in parallel through a ThreadPoolExecutor in order to
save processing time.

Without this patch, it takes almost ~5min to run all the validations but
only ~1min10 with the ThreadPoolExecutor.

- Add --worker/-w argument to give the maximum number of threads that
  can be used to execute the given validations
- Python 2.7: use futures backport instead, ThreadPoolExecutor is default
- Use six in for python 3 compatibility

Change-Id: Ia805a556bc26700a3eb520ed72e90b37546901b8
Signed-off-by: Gael Chamoulaud <>
2019-08-08 16:31:30 +02:00
Dan Prince 50744f7c22 Wire in convert_docker_params
This converts Docker*Image params into
Container*Image varients when using tripleo deploy.

In the future we can use it for a few other ad-hoc
Docker* variable substitutions as well to make things
more generic.

Change-Id: Ib1dc0c08ce7971a03639acc42b1e738d93a52f98
2019-06-12 15:14:44 +00:00
Quique Llorente c0747c0a0b Use "push" flag for buildah
The push=False flag with use with kolla-build.conf is not working if we
use buildah, clear example is the
tripleo-build-containers-centos-7-buildah job, it's suppose to work like
docker one but it's pushing too.

Closes-Bug: #1822752

Change-Id: I01788b3c11ac701b2cf8c151f95ccad7046532de
2019-04-05 13:34:20 +02:00
Kamil Sambor 1a09cf7c78 Fix tests for container image prepare
We change behaviour of what is returned by
set_neutron_driver for default network.
So we also need to change this test in tripleoclient

Change-Id: Iea3d6c7591b29f7474be97c939be60f368a04133
Closes-Bug: #1820065
2019-03-15 20:00:34 +00:00
Emilien Macchi 48525b19bc container image build: introduce --use-buildah
Support Buildah instead of Docker by calling:
  $ openstack container image build --use-buildah

And it will build TripleO containers with Buildah and not Docker.

Co-Authored-By: Alex Schultz <>
Change-Id: I7608136cb213bdca81348a0c3c751b488f48d712
2019-02-25 19:35:10 -05:00
Alex Schultz 678039164d Add excludes to container image build
Sometimes it would be beneficial to not build a specific container that
we might normally build. This change adds an --exclude option that can
be used to skip a container when passing it to kolla-build.

Change-Id: Ia871e0a46078a33270516f98ec0e08c1c3a0b43f
2019-01-03 11:45:32 -07:00
Carlos Camacho d9616842a3 Updating python-tripleoclient requires to upgrade the containers images repo
Before executing the Undercloud upgrade we need to generate
the containers image like:

openstack overcloud container image prepare \

In this case we need to have available
the correct images, otherwise we will miss
services and correct versions.

Change-Id: I108180643000ebf349648358c5ced48fce2b3dcb
Resolves: rhbz#1607421
2018-08-27 12:15:19 +02:00
Bogdan Dobrelya 6ef06fbb20 Report ansible errors in json file for standalone
Change-Id: Ia40e2144d23bfa239931180e424e142c0008e6d9
Signed-off-by: Bogdan Dobrelya <>
2018-07-13 09:10:02 +03:00
Alex Schultz f6a9761985 Save temporary working data
This change adds a new install artifact that contains the heat temporary
directory, hieradata override file, and the ansible scripts used during
the undercloud install.

This includes a new lower limit of tripleo-common 9.0.1

Depends-On: Ie00f71b12f56262985c47810be0e80402e9e558e
Depends-On: I16f19a121212d989e1184103054eb890ec4b9297
Change-Id: I62d34ea7817d5e62613ddcdbb69f2a7463273ccf
Related-Bug: #1761810
2018-04-27 09:26:08 -06:00
Doug Hellmann 465ce03d8c add lower-constraints job
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

for more details.

Update the requirement for tripleo-common to reflect reality, and update
the constraint for tenaciy.

Change-Id: Ifdf8dd1c782d6d6ac575d6fd5364dcb083e805a9
Signed-off-by: Doug Hellmann <>
2018-04-22 23:03:29 +00:00
OpenStack Proposal Bot 7632a2db45 Updated from global requirements
Change-Id: Id9ba2578ed9617d4db2c5ece3b37e431355810cb
2018-03-23 07:52:42 +00:00
OpenStack Proposal Bot 0b5515155c Updated from global requirements
Change-Id: I074657ebe66ca7cb8a483f87b0fc5fd7b09ed745
2018-03-17 09:06:21 +00:00
OpenStack Proposal Bot a0386cf090 Updated from global requirements
Change-Id: Iea01420e9fe086f0b083de400344dc580f7f5654
2018-03-13 08:25:03 +00:00
OpenStack Proposal Bot cb6a3475c0 Updated from global requirements
Change-Id: Ib23f4fc6cacaae644a0504649c5caffb35b00a59
2018-03-04 10:28:23 +00:00
OpenStack Proposal Bot 36dd874e91 Updated from global requirements
Change-Id: I1e20f91566d6387d8d4a8262613479dc856cbac7
2018-02-16 02:51:37 +00:00
Mathieu Bultel eaa2e9ce75 Get message from websocket instead from zaqarclient directly
Use the websocket api to get and print the real time
ansible execution for minor update instead of using the
zaqarclient call directly.
This is safer and avoid brutal claim of the messages.

Change-Id: I7e324b9e037197082c23a19b4e4b8832daaf5aee
2018-02-06 14:00:14 -07:00
OpenStack Proposal Bot 2a9ba1cb71 Updated from global requirements
Change-Id: I87502cf05322e506ed96fd3ab2ec2d05876e8f58
2018-01-29 00:36:49 +00:00
Juan Antonio Osorio Robles 7012843075 Handle user-provided TLS certificate/key for the undercloud
instack-undercloud has support for using a user-provided certificate and
key. This is done through the undercloud_service_certificate
configuration option. This commit adds support for the same
functionality for the containerized undercloud.

It relies on pyca/cryptography, so I added it to the requirements.txt
file. And what it does is that it will read the PEM file and add the
parameter_defaults that are needed to enable TLS.

Change-Id: I26dbde57131f6328d0c5e400dcdfdf62cdd43a41
2018-01-05 15:36:57 +02:00
OpenStack Proposal Bot 0138f0df8b Updated from global requirements
Change-Id: Ide4fc37ccfd00a300828d54cbc0617df5a4fa440
2017-12-23 14:48:34 +00:00
OpenStack Proposal Bot d122c99199 Updated from global requirements
Change-Id: I530198da52434de782b75eec438301c2795a9b0e
2017-12-21 00:47:14 +00:00
OpenStack Proposal Bot cc5fee3cab Updated from global requirements
Change-Id: I803c71b981a312ea65d6387973dcac87e4e2a06b
2017-12-03 21:53:12 +00:00
Zuul adc9ccf01e Merge "Pre-run validations and verifications for the undercloud" 2017-12-01 19:32:29 +00:00
Zuul 2c375050a6 Merge "Updated from global requirements" 2017-11-30 19:46:44 +00:00
Mathieu Bultel c102747c8d Catch zaqar exception when no message to claim
On minor update, when the execution is still running
but there is no claim message anymore, we should
capture the zaqar exception to not print it to the

Change-Id: I802ffd553c54e4a4f9998420645aa078f508b9f0
Closes-Bug: #1734957
2017-11-29 13:52:23 +00:00
Ian Main 999e0bfb31 Pre-run validations and verifications for the undercloud
Change-Id: Ief1aad319b794547bf6d75255458d08ba3be5f70
2017-11-22 17:52:53 +00:00
OpenStack Proposal Bot d4e43f1332 Updated from global requirements
Change-Id: I649d10cd86e713509b30940a0e014304379da313
2017-11-16 11:26:59 +00:00
OpenStack Proposal Bot a9b5d75ef1 Updated from global requirements
Change-Id: I4223d0fa51f2c761fb86e4dd9f0856beff35d73b
2017-09-11 21:49:50 +00:00
OpenStack Proposal Bot c6db7ce7a4 Updated from global requirements
Change-Id: I8b3a3f152186fed45ca153cb81c969669a70dfc8
2017-09-07 18:36:33 +00:00
Jehoszafat Zimnowoda b60d221fe1 Use simplejson to load json file
The simplejson extends json library. It provides sufficient information about
JSON syntax errors, which often occurs during instackenv.json file creation.

Change-Id: Ied1c080678af728820e02b7b99c51762b49b1449
Closes-Bug: #1693442
Depends on external:
2017-07-24 23:05:35 +02:00
OpenStack Proposal Bot b4c2b6f544 Updated from global requirements
Change-Id: I56092a359e1d8e4f9f8559a2d853ca3940913d8c
2017-07-21 05:08:13 +00:00
Ben Nemec 12299487f8 Revert "Call undercloud install function directly"
This broke undercloud upgrades - tripleoclient imports
instack_undercloud.undercloud, then upgrades the package.
This means the upgrade call then runs against the old version
of the module, which is incompatible with some of the new
puppet stuff.

Closes-Bug: 1701362

This reverts commit b6e71724e0.

Change-Id: Ie79dfff667437305ff4109da5a9c42ae358b1a3e
2017-06-30 14:14:25 +00:00
Ben Nemec b6e71724e0 Call undercloud install function directly
For about 2 years we've been indirectly calling the undercloud
install function through a bash script.  Originally this was done
to allow for some backwards compatibility with mismatched packages,
but later it was kept because a direct call broke logging.  This
is no longer a problem, probably due to some changes in how logging
in instack-undercloud works.

Change-Id: If07880e4bc25cffe485704772d64f62288a1a53d
Depends-On: Iff76f639bcacb5bcc1274fd837e47d34041afa15
Related bp undercloud-upgrade
2017-06-19 19:22:59 +00:00