Commit Graph

2699 Commits (6745f102791538a6696e1c0bec577be800f01170)

Author SHA1 Message Date
Alex Schultz 6745f10279 Fix command docs generation
Since we added a tripleoclient.v2 namespace, we need to update the auto
doc namespace so it finds the commands.

Change-Id: I7b5266e00af68e1d6efc9cc022fb97d002f5241b
Closes-Bug: #1866410
2020-03-09 13:10:10 -06:00
Zuul ed75570496 Merge "Start moving the import CLI command to the Ansible implementation" 2020-03-07 02:50:26 +00:00
Zuul 176fdb52cb Merge "Cleanup playbook execution" 2020-03-06 22:02:07 +00:00
Michele Baldessari bba24caafc Make _get_undercloud_host_entry(self) python3 friendly
On CentOS8 we can fail with:

    unable to pull image: Error initializing source docker://undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp16-openstack-cinder-volume:20200305.1: error pinging docker registry undercloud-0.ctlplane.redhat.local:8787: Get http://undercloud-0.ctlplane.redhat.local:8787/v2/: dial tcp: lookup undercloud-0.ctlplane.redhat.local: no such host

The reason for that is a wrong entry in /etc/hosts:
$  grep undercloud-0 controller-0/etc/hosts
b' undercloud-0.ctlplane.redhat.local undercloud-0.ctlplane\n'

The reason for this is that we invoked 'getent hosts' without passing
'universal_newlines=True' to subprocess.Popen()

Tested this and I correctly get past the issue that was observed
(seen for the first time via rhbz#1810898)

Change-Id: I2f13885a3056dd7690e9a00e2b1f7bc6aa78fff7
Closes-Bug: #1866313
2020-03-06 13:04:35 +01:00
Zuul 3b2718af8a Merge "update containers-multinode, minion to centos-8" 2020-03-06 08:31:55 +00:00
Zuul e1128ff8e4 Merge "Remove mistral when running the validate_nodes" 2020-03-06 08:04:32 +00:00
Zuul 8f356c89db Merge "Partial Revert "Replace ansible shell with python runner"" 2020-03-06 04:17:20 +00:00
Zuul d1ce930c54 Merge "Fix delete plan" 2020-03-06 03:48:51 +00:00
Zuul b215e6052c Merge "Fix KeyError exception on check_deprecated_parameters" 2020-03-06 03:48:50 +00:00
Zuul 33661ec1f6 Merge "Update undercloud.conf with correct SSL information" 2020-03-06 01:56:13 +00:00
Kevin Carter 9c7bd24720 Remove mistral when running the validate_nodes
This change removes all of mistral from the validate_nodes workflow
by calling the required functions directly.

Story: 2007212
Task: 38440

Change-Id: Ic340fad0d7305188cf3bf33a73d36cd20fca4f6b
Signed-off-by: Kevin Carter <>
2020-03-05 17:18:03 -06:00
Alex Schultz bf2e56b140 Partial Revert "Replace ansible shell with python runner"
This is a partial revert of bcc9c66747.
The change broke using non-fully qualified paths for the overcloud
deploy command. This puts the code back that fixes using a local
environment file during the deployment.

Change-Id: Ia0fc3ef70a1f3938ccccfd778cec24628bbee1fe
Closes-Bug: #1866249
2020-03-05 14:17:25 -07:00
Kevin Carter 31e631e950 Fix delete plan
This change fixes the delete plan function which was building context
incorrectly and raising a soon to be irrelevant exception in the event
of a failure.

Change-Id: I063cecaeb89b7103938fd9545c5fb976e7e17e95
Closes-Bug: #1866247
Signed-off-by: Kevin Carter <>
2020-03-05 14:32:38 -06:00
Arx Cruz 14f52713c4 Fix KeyError exception on check_deprecated_parameters
heat_resource_tree_params is returning a KeyError.
Probably this was not caught before because it always had this key.
If the key doesn't exist, returning a empty dictionary because of
several for loops used and NoneType is not iterable.

Change-Id: I745c43b8b4461ae2f60834a262ab358a7434efeb
Closes-Bug: #1866184
2020-03-05 19:43:58 +00:00
Zuul 3c7a14d668 Merge "Skip network check with stack env when validations disabled" 2020-03-05 18:31:30 +00:00
Zuul 55107c864e Merge "overcloud: set DeployIdentifier to '' if --skip-deploy-identifier is used" 2020-03-05 18:31:29 +00:00
Wes Hayutin 9bab4be307 update containers-multinode, minion to centos-8
Change-Id: I903729bcf0d6212bb542e3536140da9b44824b30
2020-03-05 09:51:12 -07:00
Zuul d648a6ba0d Merge "Avoid TZ issues in test_image test" 2020-03-05 16:38:21 +00:00
Rabi Mishra d8a7eaf88c Skip network check with stack env when validations disabled
Allow for bypassing check_stack_network_matches_env_files()
when --disable-validations is provided.

Change-Id: Ie24163a39a68ec73ae8ea5ad1011eb3789961077
Closes-Bug: #1866155
2020-03-05 12:37:09 +05:30
Zuul 0b1f3e73ff Merge "Remove mistral when creating the overcloudrc file." 2020-03-05 02:44:40 +00:00
Zuul 8022d9cd42 Merge "Remove the mistral from the check_deprecated_parameters workflow" 2020-03-05 02:31:30 +00:00
Emilien Macchi 5685cd24af overcloud: set DeployIdentifier to '' if --skip-deploy-identifier is used
Similar to Ib1928b60ba7b03983f303577a53df078d32d2b1b, ensure that
DeployIdentifier is empty if --skip-deploy-identifier is used.

Change-Id: I1eaa845bfc18b1c77e8463582ee13c173b62bb38
Related-Bug: #1866135
2020-03-04 19:15:05 -05:00
Sagi Shnaidman 1ce32574d1 Avoid TZ issues in test_image test
Compare only minute and seconds when comparing timestamps
Change-Id: Ic0c246ff60579b8079279141b4c541b4f2105f6e
2020-03-04 17:47:58 +02:00
Zuul c1a48c377f Merge "Pass verbose boolean value to wait_for_stack_ready()" 2020-03-04 12:13:50 +00:00
Emilien Macchi b5df6b265d Update undercloud.conf with correct SSL information
The generated certificates are located:

Because in environments/ssl/enable-tls.yaml, we can find:
DeployedSSLCertificatePath: /etc/pki/tls/private/overcloud_endpoint.pem

Update the doc, so there is no confusion.

Change-Id: I974167d0d2d04a94dc8a82a361a9ca1425364935
2020-03-03 19:09:03 -05:00
Wes Hayutin f6121c4b0f migrate from centos7 -> centos-8 for standalone jobs
scenario1-4 available on centos-8 now

Related-Bug: #1865525
Change-Id: I72530514d7d2641eb1a53c31402bc9cbf2887a78
2020-03-02 09:32:41 -07:00
Zuul 9a7b900a53 Merge "Relax ~/.config permissions" 2020-03-02 15:56:36 +00:00
Emilien Macchi 3e695291de Relax ~/.config permissions
When creating clouds.yaml, ensure that ~/.config remains owned by the
deployment user.

Change-Id: Ibf211ad83b4fbe9d790c710bf1338eff9727b4c6
Closes-Bug: #1864940
2020-03-02 09:12:48 +00:00
Dougal Matthews 3ee3bea8ad Remove Mistral from the plan export
Change-Id: I54feb077d7cd4bc1b1b5750e402f743e5aef60e4
2020-03-02 09:11:41 +00:00
Zuul ecebb3d257 Merge "Fix unit test_get_image timezone issue" 2020-02-29 06:18:07 +00:00
Zuul 735acf94e3 Merge "Get validation groups info from groups.yaml file" 2020-02-29 02:41:37 +00:00
Zuul 88986bd7d3 Merge "TripleO Validations Logging CLI Introduction" 2020-02-29 02:41:36 +00:00
Luke Short 0e901cda25 Remove mistral when creating the overcloudrc file.
Remove the mistral indirection and Use the tripleo-common
infrastructure directly when creating an overcloudrc file.

Story: 2007212
Task: 38426

Change-Id: Iaf6a401f510b768f26f3ff95a9c47d2d1dced71d
Signed-off-by: Kevin Carter <>
2020-02-28 11:38:51 +01:00
Kevin Carter 8416553903 Remove the mistral from the check_deprecated_parameters workflow
This change removes all of mistral from the check_deprecated_parameters
function by calling the required functions directly.

Story: 2007212
Task: 38424

Change-Id: Ib76dac4e0d11c66fe90c30db19788af1cb4694f6
Signed-off-by: Kevin Carter <>
2020-02-28 11:38:51 +01:00
Zuul 72bb7fbaa9 Merge "Fix default image registry address lookup" 2020-02-28 05:24:21 +00:00
Zuul 320d232e80 Merge "Fix create_container regression" 2020-02-28 05:24:18 +00:00
Gael Chamoulaud (Strider) afb9887a40 Get validation groups info from groups.yaml file
This patch makes the VALIDATION_GROUPS list constants dynamic by getting
them from the 'groups.yaml' file. This file comes from
tripleo-validations and is present on the Undercloud at the location [1].

[1] => /usr/share/openstack-tripleo-validations

Change-Id: Ide8cba32a0ea14086714094291f1a8866b669491
Signed-off-by: Gael Chamoulaud (Strider) <>
2020-02-27 09:26:03 +00:00
Zuul e4e11d6905 Merge "Migrate the openstack overcloud delete command to use Ansible" 2020-02-27 04:29:42 +00:00
Rabi Mishra 0eb3573c21 Fix create_container regression
This is a regression from

Change-Id: I3819008275f6a5288ec074c860ff2746f589193e
Closes-Bug: #1864862
2020-02-27 07:43:02 +05:30
Zuul 04f6da1400 Merge "Increase ssh port timeout" 2020-02-26 22:30:06 +00:00
Zuul 4fc6009f37 Merge "Add handler for exception raising" 2020-02-26 22:12:06 +00:00
Zuul 8a0f1cacd5 Merge "Add source auth to image push" 2020-02-26 18:45:21 +00:00
Gael Chamoulaud 4fbd5ffe4f
TripleO Validations Logging CLI Introduction
This patch adds logging support for validations. It introduces two new
Tripleo Validator commands to allow the user to get the executions
history and get the details of them.

Change-Id: Ie80318a7fa684adb7c3bf7c99d526b0de64b0904
Depends-On: I502c38d3f27db3c6f62a47190136dd03627956bc
Depends-On: I0cb2743d1d4d118320a799c6820d48f9b917498f
Signed-off-by: Gael Chamoulaud <>
2020-02-26 14:34:41 +01:00
Harald Jensås aa0504a46f Fix unit test_get_image timezone issue
tripleoclient unit tests fail due to timezone no UTC.
MismatchError: '2019-11-14T01:33:39' != '2019-11-14T02:33:39'

Closes-Bug: #1864828
Change-Id: I076f786e8d5ca756e5d73d04e84c4084ec24c579
2020-02-26 11:43:49 +01:00
Zuul d6e526a9de Merge "Don't use the delete_deployment_plan workflow, call the action directly" 2020-02-26 08:18:21 +00:00
Zuul cdc32888a4 Merge "Local file based image uploader" 2020-02-26 07:57:45 +00:00
Rabi Mishra 5f9b43a8dc Pass verbose boolean value to wait_for_stack_ready()
Though it works, it's better to pass boolean value to avoid
confusion with the nested_depth parameter.

Change-Id: I4b40356413c201314bf859dd4141bf995aac4965
2020-02-26 08:35:22 +05:30
Zuul fbfd70c7e4 Merge "Revert "Default to zero verbosity when using Ansible."" 2020-02-26 02:45:00 +00:00
Zuul 58c0c2fb76 Merge "Remove mistral from the generate_fencing_parameters deploy workflow" 2020-02-26 01:02:41 +00:00
Alex Schultz 1458e27509 Increase ssh port timeout
It's been reported that we still failing too quickly for some
environments with a mix of vms and physical hardware. Let's increase the
default ssh port timeout to 600 seconds to work around this.

See also:
Related-Bug: #1805725

Change-Id: I95ddc0b7cb6342c367772b0cf296ee372dbb92dd
2020-02-25 14:47:14 -07:00