python-tripleoclient/dd5efa60b6f7386a409febf3d6997d3a7e287826

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "571ba431_63db672c",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 8297
      },
      "writtenOn": "2023-03-22T16:00:23Z",
      "side": 1,
      "message": "If you want/get another round of review, here are thoughts about small improvement.  Not blocking.",
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "12bd81e3_04c1e15a",
        "filename": "tripleoclient/utils.py",
        "patchSetId": 3
      },
      "lineNbr": 233,
      "author": {
        "id": 8297
      },
      "writtenOn": "2023-03-22T16:00:23Z",
      "side": 1,
      "message": "Maybe we should add this functionality to the doc string of the limit option ?",
      "range": {
        "startLine": 233,
        "startChar": 0,
        "endLine": 233,
        "endChar": 46
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "a4f016c1_a2ae1c8c",
        "filename": "tripleoclient/utils.py",
        "patchSetId": 3
      },
      "lineNbr": 233,
      "author": {
        "id": 33080
      },
      "writtenOn": "2023-03-23T08:18:21Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "12bd81e3_04c1e15a",
      "range": {
        "startLine": 233,
        "startChar": 0,
        "endLine": 233,
        "endChar": 46
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "29ec0a19_a6d97a10",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 207,
      "author": {
        "id": 8297
      },
      "writtenOn": "2023-03-22T16:00:23Z",
      "side": 1,
      "message": "fixed string no need for format.",
      "range": {
        "startLine": 205,
        "startChar": 25,
        "endLine": 207,
        "endChar": 55
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e86b8f75_8eda4268",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 207,
      "author": {
        "id": 33080
      },
      "writtenOn": "2023-03-23T08:18:21Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "29ec0a19_a6d97a10",
      "range": {
        "startLine": 205,
        "startChar": 25,
        "endLine": 207,
        "endChar": 55
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "4499bca4_911b2f03",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 208,
      "author": {
        "id": 8297
      },
      "writtenOn": "2023-03-22T16:00:23Z",
      "side": 1,
      "message": "Maybe we could add \u0027:!{}\u0027 instead and avoid the reprocessing of it with playbook_limit_parse",
      "range": {
        "startLine": 208,
        "startChar": 26,
        "endLine": 208,
        "endChar": 30
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d9c56ade_a3c843be",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 208,
      "author": {
        "id": 8297
      },
      "writtenOn": "2023-03-22T16:00:23Z",
      "side": 1,
      "message": "This is a fixed string, let\u0027s just add a string then, format is not required.",
      "range": {
        "startLine": 208,
        "startChar": 28,
        "endLine": 208,
        "endChar": 62
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "217ee5aa_e7d34064",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 208,
      "author": {
        "id": 33080
      },
      "writtenOn": "2023-03-23T08:18:21Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "d9c56ade_a3c843be",
      "range": {
        "startLine": 208,
        "startChar": 28,
        "endLine": 208,
        "endChar": 62
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7f5c6632_5d303580",
        "filename": "tripleoclient/v1/overcloud_update.py",
        "patchSetId": 3
      },
      "lineNbr": 208,
      "author": {
        "id": 33080
      },
      "writtenOn": "2023-03-23T08:18:21Z",
      "side": 1,
      "message": "Fixed to :!{} , but reprocessing stays as it won\u0027t hurt to reporcess string again.",
      "parentUuid": "4499bca4_911b2f03",
      "range": {
        "startLine": 208,
        "startChar": 26,
        "endLine": 208,
        "endChar": 30
      },
      "revId": "dd5efa60b6f7386a409febf3d6997d3a7e287826",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}