7a044ca251
Update/Upgrade commands have now a prompt by default that ask for confirmation before proceeding. It'll prevent an user to run the command that may cause the problems to infrastructure. This prompt can be skipped with --yes/-y argument. Note: putting "UPDATE" and "UPGRADE" in uppercase to make sure this is visible and clear. We have seen many users running the wrong command and ending up doing an upgrade instead of an update. Note2: this prompt will be ported to the upgrade and FFWD workflows to prevent unexpected execution to prevent potential harm to infrastructures. Depends-On: https://review.opendev.org/741480 Change-Id: I838e6748879c668dd004ca2243b7b00b857c2a7b
153 lines
6.3 KiB
Python
153 lines
6.3 KiB
Python
# Copyright 2018 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
from oslo_config import cfg
|
|
from oslo_log import log as logging
|
|
|
|
from osc_lib.i18n import _
|
|
from osc_lib import utils
|
|
|
|
from tripleoclient.exceptions import OvercloudUpdateNotConfirmed
|
|
|
|
from tripleoclient import command
|
|
from tripleoclient import constants
|
|
from tripleoclient import utils as oooutils
|
|
from tripleoclient.workflows import deployment
|
|
|
|
|
|
CONF = cfg.CONF
|
|
logging.register_options(CONF)
|
|
logging.setup(CONF, '')
|
|
|
|
|
|
class ExternalUpdateRun(command.Command):
|
|
"""Run external minor update Ansible playbook
|
|
|
|
This will run the external minor update Ansible playbook,
|
|
executing tasks from the undercloud. The update playbooks are
|
|
made available after completion of the 'overcloud update
|
|
prepare' command.
|
|
|
|
"""
|
|
|
|
log = logging.getLogger(__name__ + ".ExternalUpdateRun")
|
|
|
|
def get_parser(self, prog_name):
|
|
parser = super(ExternalUpdateRun, self).get_parser(prog_name)
|
|
parser.add_argument('--static-inventory',
|
|
dest='static_inventory',
|
|
action="store",
|
|
default=None,
|
|
help=_('Path to an existing ansible inventory to '
|
|
'use. If not specified, one will be '
|
|
'generated in '
|
|
'~/tripleo-ansible-inventory.yaml')
|
|
)
|
|
parser.add_argument("--ssh-user",
|
|
dest="ssh_user",
|
|
action="store",
|
|
default="tripleo-admin",
|
|
help=_("DEPRECATED: Only tripleo-admin should be "
|
|
"used as ssh user.")
|
|
)
|
|
parser.add_argument('--tags',
|
|
dest='tags',
|
|
action="store",
|
|
default="",
|
|
help=_('A string specifying the tag or comma '
|
|
'separated list of tags to be passed '
|
|
'as --tags to ansible-playbook. ')
|
|
)
|
|
parser.add_argument('--skip-tags',
|
|
dest='skip_tags',
|
|
action="store",
|
|
default="",
|
|
help=_('A string specifying the tag or comma '
|
|
'separated list of tags to be passed '
|
|
'as --skip-tags to ansible-playbook. ')
|
|
)
|
|
parser.add_argument('--stack', dest='stack',
|
|
help=_('Name or ID of heat stack '
|
|
'(default=Env: OVERCLOUD_STACK_NAME)'),
|
|
default=utils.env('OVERCLOUD_STACK_NAME',
|
|
default='overcloud'))
|
|
parser.add_argument('-e', '--extra-vars', dest='extra_vars',
|
|
action='append',
|
|
help=('Set additional variables as key=value or '
|
|
'yaml/json'),
|
|
default=[])
|
|
parser.add_argument('--no-workflow', dest='no_workflow',
|
|
action='store_true',
|
|
default=True,
|
|
help=_('This option no longer has any effect.')
|
|
)
|
|
parser.add_argument('-y', '--yes', default=False,
|
|
action='store_true',
|
|
help=_("Use -y or --yes to skip the confirmation "
|
|
"required before any upgrade "
|
|
"operation. Use this with caution! "),
|
|
)
|
|
parser.add_argument(
|
|
'--limit',
|
|
action='store',
|
|
default=None,
|
|
help=_("A string that identifies a single node or comma-separated"
|
|
"list of nodes the config-download Ansible playbook "
|
|
"execution will be limited to. For example: --limit"
|
|
" \"compute-0,compute-1,compute-5\".")
|
|
)
|
|
|
|
return parser
|
|
|
|
def take_action(self, parsed_args):
|
|
self.log.debug("take_action(%s)" % parsed_args)
|
|
|
|
if (not parsed_args.yes
|
|
and not oooutils.prompt_user_for_confirmation(
|
|
constants.UPDATE_PROMPT, self.log)):
|
|
raise OvercloudUpdateNotConfirmed(constants.UPDATE_NO)
|
|
|
|
_, ansible_dir = self.get_ansible_key_and_dir(
|
|
no_workflow=True,
|
|
stack=parsed_args.stack,
|
|
orchestration=self.app.client_manager.orchestration
|
|
)
|
|
deployment.config_download(
|
|
log=self.log,
|
|
clients=self.app.client_manager,
|
|
stack=oooutils.get_stack(
|
|
self.app.client_manager.orchestration,
|
|
parsed_args.stack
|
|
),
|
|
output_dir=ansible_dir,
|
|
verbosity=oooutils.playbook_verbosity(self=self),
|
|
ansible_playbook_name=constants.EXTERNAL_UPDATE_PLAYBOOKS,
|
|
extra_vars=oooutils.parse_extra_vars(
|
|
extra_var_strings=parsed_args.extra_vars
|
|
),
|
|
inventory_path=oooutils.get_tripleo_ansible_inventory(
|
|
parsed_args.static_inventory,
|
|
parsed_args.ssh_user,
|
|
parsed_args.stack,
|
|
return_inventory_file_path=True
|
|
),
|
|
tags=parsed_args.tags,
|
|
skip_tags=parsed_args.skip_tags,
|
|
limit_hosts=oooutils.playbook_limit_parse(
|
|
limit_nodes=parsed_args.limit
|
|
)
|
|
)
|
|
self.log.info("Completed Overcloud External Update Run.")
|