openstack
/
python-tripleoclient
Code Issues Proposed changes
RETIRED, python utility to manage a tripleo based cloud
2,461 Commits 3 Branches 30 Tags 71 MiB
Go to file
Michele Baldessari 99a96ef416 Close some file descriptors that were left open 
Before:
(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json
/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file <_io.TextIOWrapper name='fencetest.yaml' mode='w' encoding='UTF-8'>
  ret_value = super(OpenStackShell, self).run_subcommand(argv)
/usr/lib/python3.6/site-packages/osc_lib/shell.py:176: ResourceWarning: unclosed file <_io.TextIOWrapper name='instackenv.json' mode='r' encoding='UTF-8'>
  ret_value = super(OpenStackShell, self).run_subcommand(argv)
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 56494), raddr=('192.168.24.2', 13000)>
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=9, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 54102), raddr=('192.168.24.2', 13989)>

After:
(undercloud) [stack@undercloud-0 ~]$ openstack overcloud generate fencing --output fencetest.yaml instackenv.json
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 47694), raddr=('192.168.24.2', 13000)>
sys:1: ResourceWarning: unclosed <ssl.SSLSocket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('192.168.24.2', 45306), raddr=('192.168.24.2', 13989)>

Note that we also explicitly close an opened FileType in tripleoclient/v1/overcloud_execute.py
as it was spotted while writing this review.

NB: The SSL warnings will be investigated separately

Change-Id: Ic8122ad1982deed0434d797a3fb0fba8512b27ab
Closes-Bug: #1845927
 		2019-10-01 06:49:02 +00:00
config-generator Add minion installation 2019-06-21 07:44:21 -06:00
doc PDF documentation build 2019-09-11 16:33:21 +02:00
releasenotes Merge "Deprecate overcloud image prepare" 2019-09-19 19:09:36 +00:00
tripleoclient Close some file descriptors that were left open 2019-10-01 06:49:02 +00:00
zuul.d Disable voting on openstack-tox-py27 2019-09-27 15:29:18 +00:00
.coveragerc Update .coveragerc after the removal of respective directory 2016-10-18 17:37:29 +05:30
.gitignore Add minion installation 2019-06-21 07:44:21 -06:00
.gitreview OpenDev Migration Patch 2019-04-19 19:42:47 +00:00
.mailmap Initial commit 2015-03-17 09:33:52 -04:00
.stestr.conf Switch to stestr 2019-01-04 17:31:21 +00:00
CONTRIBUTING.rst PDF documentation build 2019-09-11 16:33:21 +02:00
LICENSE Initial commit 2015-03-17 09:33:52 -04:00
README.rst PDF documentation build 2019-09-11 16:33:21 +02:00
babel.cfg Initial commit 2015-03-17 09:33:52 -04:00
bindep.txt Set policycoreutils package name for RHEL/CentOS 8 2019-09-09 10:18:58 +00:00
lower-constraints.txt Run Validations with ThreadPoolExecutor 2019-08-08 16:31:30 +02:00
requirements.txt Run Validations with ThreadPoolExecutor 2019-08-08 16:31:30 +02:00
setup.cfg Merge "New command "openstack overcloud node unprovision"" 2019-09-06 06:31:41 +00:00
setup.py Updated from global requirements 2017-03-07 02:06:19 +00:00
test-requirements.txt Merge "Update hacking version" 2019-01-17 18:09:31 +00:00
tox.ini PDF documentation build 2019-09-11 16:33:21 +02:00

README.rst

About tripleoclient

General information

tripleoclient is an OpenStackClient (OSC) plugin implementation that implements commands useful for TripleO and the install and management of both an undercloud and an overcloud.

See the TripleO Documentation for details on using tripleoclient.

See the Release Notes

Team and repository tags

image