97 lines
3.0 KiB
Plaintext
97 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b182323e_ce2aabbf",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2023-03-15T01:52:37Z",
|
|
"side": 1,
|
|
"message": "It has been a while since we discussed how we manage CIP but do we need this part ? My earlier expectation was that we can use the default images pullsed by top-level ContainerImagePrepare.",
|
|
"range": {
|
|
"startLine": 27,
|
|
"startChar": 2,
|
|
"endLine": 27,
|
|
"endChar": 13
|
|
},
|
|
"revId": "37a69826054ba926eaf8ec6fca03e000159cac25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "93317da2_7f6994a1",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 63,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2023-03-15T01:52:37Z",
|
|
"side": 1,
|
|
"message": "If the main aim is to create this part then I\u0027d probably suggest adding --role and --includes to the default command so that the result is rendered to role specific version with includes.\n\nYou can run the command two times, with these options and without these options, and then use both of the two files generated separately by adding -e \u003cbase\u003e -e \u003crole specific\u003e",
|
|
"range": {
|
|
"startLine": 63,
|
|
"startChar": 4,
|
|
"endLine": 63,
|
|
"endChar": 12
|
|
},
|
|
"revId": "37a69826054ba926eaf8ec6fca03e000159cac25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fcb509ff_4a840c4d",
|
|
"filename": "tripleoclient/v1/container_image.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 449,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2023-03-15T01:52:37Z",
|
|
"side": 1,
|
|
"message": "multi-rhel is not appropriate naming for upstream patches. If we pursue this name then IMO this should be downstream-only.",
|
|
"range": {
|
|
"startLine": 449,
|
|
"startChar": 22,
|
|
"endLine": 449,
|
|
"endChar": 32
|
|
},
|
|
"revId": "37a69826054ba926eaf8ec6fca03e000159cac25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b2f932f5_f450caa8",
|
|
"filename": "tripleoclient/v1/container_image.py",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 449,
|
|
"author": {
|
|
"id": 6816
|
|
},
|
|
"writtenOn": "2023-03-15T09:14:19Z",
|
|
"side": 1,
|
|
"message": "Can you suggest an alternative name? IIUC this would be used both upstream and downstream.",
|
|
"parentUuid": "fcb509ff_4a840c4d",
|
|
"range": {
|
|
"startLine": 449,
|
|
"startChar": 22,
|
|
"endLine": 449,
|
|
"endChar": 32
|
|
},
|
|
"revId": "37a69826054ba926eaf8ec6fca03e000159cac25",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |