74 lines
2.7 KiB
Plaintext
74 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5d1aa8ae_0a5b574f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33080
|
|
},
|
|
"writtenOn": "2023-02-10T13:57:01Z",
|
|
"side": 1,
|
|
"message": "Is there a doc change with the example from commit message and some description?\nMaybe it is also worth creating a test for this new flags?",
|
|
"revId": "cb2139a0f80458f357db309f9852735f03891ebf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9911263d_8885077a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 22954
|
|
},
|
|
"writtenOn": "2023-02-13T09:51:01Z",
|
|
"side": 1,
|
|
"message": "There is no documentation available. No sure whether this is going to be used. But I will write the documentation to be added on the commit message at least.\nRegarding the test case, I would like to have some feedback before working more on this TBH, but I agree with you, to have this patch merged this needs to be covered by the unit test.",
|
|
"parentUuid": "5d1aa8ae_0a5b574f",
|
|
"revId": "cb2139a0f80458f357db309f9852735f03891ebf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "760a0484_53251b3b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 30073
|
|
},
|
|
"writtenOn": "2023-03-07T21:53:56Z",
|
|
"side": 1,
|
|
"message": "I\u0027m not sure we want this kind of complex logic directly in tripleoclient tbh. \n\nIf we want to provide this kind of tool for users, it might be better off as a bespoke tool. Maybe we can ship it as part of triple-common instead? It\u0027s just a lot of complex logic for us to carry for the limited subset of users that will take advantage of multi-rhel.\n\n",
|
|
"revId": "cb2139a0f80458f357db309f9852735f03891ebf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "416f57b0_aa1195c3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 22954
|
|
},
|
|
"writtenOn": "2023-03-14T12:08:07Z",
|
|
"side": 1,
|
|
"message": "Is https://review.opendev.org/c/openstack/tripleo-heat-templates/+/877363 a better option?\n\nIt also need test.",
|
|
"parentUuid": "760a0484_53251b3b",
|
|
"revId": "cb2139a0f80458f357db309f9852735f03891ebf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |