python-tripleoclient/dec71c42399a46d571d0fdf8a901e78582d14c14

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "c3b0d71c_03ccc087",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 8449
      },
      "writtenOn": "2023-01-20T07:59:57Z",
      "side": 1,
      "message": "for me this is very confusing (as is the argument name --exclude-include)\n\ni think you mean exclude really? so just --exclude ? or i misunderstood what it is used for",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ce24e40b_899e873e",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 22954
      },
      "writtenOn": "2023-01-23T13:18:59Z",
      "side": 1,
      "message": "Well, these are the services that are going to be exclude from the minor version, and only the major version are going to be used. That\u0027s why the exclude-include thing.\n\nSomething like:\n  ComputeHCIContainerImagePrepare: \u0026id001\n  - excludes:\n    - nova-compute\n    - nova-libvirt\n    - ovn-controller\n    set:\n    ...\n    ....\n    ....",
      "parentUuid": "c3b0d71c_03ccc087",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "19e9cb2b_6b984dd0",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 6816
      },
      "writtenOn": "2023-01-24T12:01:48Z",
      "side": 1,
      "message": "Maybe make this two args?\n\n--service-exclude\n--service-include",
      "parentUuid": "ce24e40b_899e873e",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7cf771df_bc2951f0",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 22954
      },
      "writtenOn": "2023-01-24T13:48:57Z",
      "side": 1,
      "message": "Well, the point is that the exclude service needs to be included, or at least it\u0027s what I think.",
      "parentUuid": "19e9cb2b_6b984dd0",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8a162815_7b389ebd",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 6816
      },
      "writtenOn": "2023-01-24T15:09:52Z",
      "side": 1,
      "message": "If this is just the list of items in the \u0027excludes\u0027 key, then perhaps it\u0027s better to just make the arg \u0027--excludes\u0027.",
      "parentUuid": "7cf771df_bc2951f0",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e68daf04_7f0037c2",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 459,
      "author": {
        "id": 22954
      },
      "writtenOn": "2023-01-24T16:47:50Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "8a162815_7b389ebd",
      "range": {
        "startLine": 459,
        "startChar": 43,
        "endLine": 459,
        "endChar": 51
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e03b22da_88346eea",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 462,
      "author": {
        "id": 8449
      },
      "writtenOn": "2023-01-20T07:59:57Z",
      "side": 1,
      "message": "major?",
      "range": {
        "startLine": 462,
        "startChar": 17,
        "endLine": 462,
        "endChar": 18
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "aaf360b2_2985e7db",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 462,
      "author": {
        "id": 22954
      },
      "writtenOn": "2023-01-23T13:18:59Z",
      "side": 1,
      "message": "yeap, this need to be fixed.",
      "parentUuid": "e03b22da_88346eea",
      "range": {
        "startLine": 462,
        "startChar": 17,
        "endLine": 462,
        "endChar": 18
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "da89ce28_543b1dbc",
        "filename": "tripleoclient/v1/container_image.py",
        "patchSetId": 6
      },
      "lineNbr": 462,
      "author": {
        "id": 22954
      },
      "writtenOn": "2023-01-24T13:48:57Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "aaf360b2_2985e7db",
      "range": {
        "startLine": 462,
        "startChar": 17,
        "endLine": 462,
        "endChar": 18
      },
      "revId": "dec71c42399a46d571d0fdf8a901e78582d14c14",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}