openstack/python-troveclient
Code Issues Proposed changes

Replace assertDictEqual

Browse Source 
Here,assertDictEqual is test that two dictionaries are equal.This method
will be used by default to compare dictionaries in calls to assertEqual.
So,I replace assertDictEqual.

refer to [1] for more information

[1]:https://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertDictEqual

Change-Id: Idb30eeab13e9cad44e7c78c7903280f5e3bf66d6
This commit is contained in:
jiansong
2016-07-28 00:56:31 -07:00
committed by jian.song
parent 49c6fa13de
commit 2093cba59e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
troveclient/tests/test_client.py
View File

@@ -376,7 +376,7 @@ class ClientTest(testtools.TestCase):
called_args, called_kwargs = mock_request.call_args called_args, called_kwargs = mock_request.call_args
self.assertEqual(('POST', 'http://www.blah.com/v2.0/tokens'), self.assertEqual(('POST', 'http://www.blah.com/v2.0/tokens'),
called_args) called_args)
self.assertDictEqual(headers, called_kwargs['headers']) self.assertEqual(headers, called_kwargs['headers'])
def test_client_get(self): def test_client_get(self):
auth_url = 'http://www.blah.com' auth_url = 'http://www.blah.com'

2
troveclient/tests/test_management.py
View File

@@ -273,7 +273,7 @@ class MgmtDatastoreVersionsTest(testtools.TestCase):
self._resp.status_code = 202 self._resp.status_code = 202
self.ds_version.edit('ds-version-1', image="new-image-id") self.ds_version.edit('ds-version-1', image="new-image-id")
self.assertEqual('/mgmt/datastore-versions/ds-version-1', self._url) self.assertEqual('/mgmt/datastore-versions/ds-version-1', self._url)
self.assertDictEqual({"image": "new-image-id"}, self._body) self.assertEqual({"image": "new-image-id"}, self._body)
self._resp.status_code = 400 self._resp.status_code = 400
self.assertRaises(Exception, self.ds_version.edit, 'ds-version-1', self.assertRaises(Exception, self.ds_version.edit, 'ds-version-1',