openstack/python-troveclient
Code Issues Proposed changes

Fix inadvertent generation of file during tox test

Browse Source 
When running py27 or py34 tox tests, a '4321_4321_4321.dat' file is
created and not cleaned up. This is due to a missing mock in the
module_retrieve test.

The 'open' method is now mocked and the file is not created.

Change-Id: I8e2524961b3cb2ac01b65d5ce11d476ad3a81662
Closed-Bug: #1565959
This commit is contained in:
Peter Stachowski 2016-04-04 19:09:25 +00:00
parent 4b2d76931b
commit 967f0ff837
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
troveclient/tests/test_v1_shell.py
View File

@ -600,11 +600,12 @@ class ShellTest(utils.TestCase):
def test_module_retrieve(self): def test_module_retrieve(self):
with mock.patch.object(troveclient.v1.modules.Module, '__getattr__', with mock.patch.object(troveclient.v1.modules.Module, '__getattr__',
mock.Mock(return_value='4321')): mock.Mock(return_value='4321')):
self.run_command('module-retrieve 1234') with mock.patch.object(builtins, 'open'):
self.assert_called( self.run_command('module-retrieve 1234')
'GET', self.assert_called(
'/instances/1234/modules?' 'GET',
'include_contents=True&from_guest=True') '/instances/1234/modules?'
'include_contents=True&from_guest=True')
def test_limit_list(self): def test_limit_list(self):
self.run_command('limit-list') self.run_command('limit-list')