openstack/python-troveclient
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual

Browse Source 
assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - https://github.com/testing-cabal/testtools/issues/286
[4] - https://github.com/testing-cabal/testtools/pull/277

Change-Id: I444b5919817b6b5cde2165872293076aff6bf6e9
This commit is contained in:
Joel Capitao
2020-06-04 14:44:51 +02:00
parent 99126428ce
commit b3f8c0b114
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
troveclient/tests/osc/v1/test_database_logs.py
View File

@@ -76,7 +76,7 @@ class TestShowDatabaseInstanceLog(TestLogs):
columns, values = self.cmd.take_action(parsed_args)
self.assertEqual(self.columns, columns)
self.assertItemsEqual(data.to_dict().values(), values)
self.assertCountEqual(data.to_dict().values(), values)
class TestSetDatabaseInstanceLog(TestLogs):