diff --git a/releasenotes/notes/victoria-create-datastore-version.yaml b/releasenotes/notes/victoria-create-datastore-version.yaml new file mode 100644 index 00000000..f4b0c668 --- /dev/null +++ b/releasenotes/notes/victoria-create-datastore-version.yaml @@ -0,0 +1,3 @@ +--- +features: + - Support to create datastore version in CLI. diff --git a/setup.cfg b/setup.cfg index 9054a386..5a4aed9a 100644 --- a/setup.cfg +++ b/setup.cfg @@ -99,6 +99,7 @@ openstack.database.v1 = datastore_list = troveclient.osc.v1.datastores:ListDatastores datastore_show = troveclient.osc.v1.datastores:ShowDatastore datastore_delete = troveclient.osc.v1.datastores:DeleteDatastore + datastore_version_create = troveclient.osc.v1.datastores:CreateDatastoreVersion datastore_version_list = troveclient.osc.v1.datastores:ListDatastoreVersions datastore_version_show = troveclient.osc.v1.datastores:ShowDatastoreVersion datastore_version_delete = troveclient.osc.v1.datastores:DeleteDatastoreVersion diff --git a/troveclient/osc/v1/datastores.py b/troveclient/osc/v1/datastores.py index 3d53927a..bf12158b 100644 --- a/troveclient/osc/v1/datastores.py +++ b/troveclient/osc/v1/datastores.py @@ -169,3 +169,54 @@ class DeleteDatastoreVersion(command.Command): msg = (_("Failed to delete datastore version %(version)s: %(e)s") % {'version': parsed_args.datastore_version, 'e': e}) raise exceptions.CommandError(msg) + + +class CreateDatastoreVersion(command.Command): + _description = _("Creates a datastore version.") + + def get_parser(self, prog_name): + parser = super(CreateDatastoreVersion, self).get_parser(prog_name) + parser.add_argument( + 'version_name', + help=_('Datastore version name.'), + ) + parser.add_argument( + 'datastore_name', + help=_("Datastore name. The datastore is created automatically " + "if does not exist."), + ) + parser.add_argument( + 'datastore_manager', + help=_('Datastore manager, e.g. mysql'), + ) + parser.add_argument( + 'image_id', + help=_('ID of the datastore image in Glance.'), + ) + parser.add_argument( + '--active', + action='store_true', + help=_('Enable the datastore version or not.'), + ) + parser.add_argument( + '--default', + action='store_true', + help=_('If set the datastore version as default.'), + ) + return parser + + def take_action(self, parsed_args): + client = self.app.client_manager.database.mgmt_ds_versions + try: + client.create( + parsed_args.version_name, + parsed_args.datastore_name, + parsed_args.datastore_manager, + parsed_args.image_id, + active='true' if parsed_args.active else 'false', + default='true' if parsed_args.default else 'false' + ) + except Exception as e: + msg = (_("Failed to create datastore version %(version)s: %(e)s") + % {'version': parsed_args.version_name, 'e': e}) + raise exceptions.CommandError(msg) diff --git a/troveclient/tests/osc/v1/test_datastores.py b/troveclient/tests/osc/v1/test_datastores.py index aa75d2c2..09f43fd8 100644 --- a/troveclient/tests/osc/v1/test_datastores.py +++ b/troveclient/tests/osc/v1/test_datastores.py @@ -156,3 +156,21 @@ class TestDeleteDatastoreVersion(TestDatastores): self.cmd.take_action(parsed_args) self.dsversion_mgmt_client.delete.assert_called_once_with(dsversion_id) + + +class TestCreateDatastoreVersion(TestDatastores): + def setUp(self): + super(TestCreateDatastoreVersion, self).setUp() + self.cmd = datastores.CreateDatastoreVersion(self.app, None) + + def test_create_datastore_version(self): + image_id = uuidutils.generate_uuid() + args = ['new_name', 'ds_name', 'ds_manager', image_id, '--active', + '--default'] + parsed_args = self.check_parser(self.cmd, args, []) + + self.cmd.take_action(parsed_args) + + self.dsversion_mgmt_client.create.assert_called_once_with( + 'new_name', 'ds_name', 'ds_manager', image_id, active='true', + default='true')