From b3f8c0b1141caad437b441bc403ce6acf241321d Mon Sep 17 00:00:00 2001 From: Joel Capitao Date: Thu, 4 Jun 2020 14:44:51 +0200 Subject: [PATCH] Replace assertItemsEqual with assertCountEqual assertItemsEqual was removed from Python's unittest.TestCase in Python 3.3 [1][2]. We have been able to use them since then, because testtools required unittest2, which still included it. With testtools removing Python 2.7 support [3][4], we will lose support for assertItemsEqual, so we should switch to use assertCountEqual. [1] - https://bugs.python.org/issue17866 [2] - https://hg.python.org/cpython/rev/d9921cb6e3cd [3] - https://github.com/testing-cabal/testtools/issues/286 [4] - https://github.com/testing-cabal/testtools/pull/277 Change-Id: I444b5919817b6b5cde2165872293076aff6bf6e9 --- troveclient/tests/osc/v1/test_database_logs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/troveclient/tests/osc/v1/test_database_logs.py b/troveclient/tests/osc/v1/test_database_logs.py index cff7256d..c9cc986a 100644 --- a/troveclient/tests/osc/v1/test_database_logs.py +++ b/troveclient/tests/osc/v1/test_database_logs.py @@ -76,7 +76,7 @@ class TestShowDatabaseInstanceLog(TestLogs): columns, values = self.cmd.take_action(parsed_args) self.assertEqual(self.columns, columns) - self.assertItemsEqual(data.to_dict().values(), values) + self.assertCountEqual(data.to_dict().values(), values) class TestSetDatabaseInstanceLog(TestLogs):