openstack/python-vitrageclient
Code Issues Proposed changes

Bump hacking

Browse Source 
hacking 3.0.x is too old. Bump it to the latest version available.

Also remove the note about old pip's behavior because recent pip does
not require specific order.

Change-Id: Ibc1ee07b20ae6271380816bed6a4a8116352cf8a
This commit is contained in:
Takashi Kajinami 2024-11-17 00:39:07 +09:00
parent 49fd3d19a1
commit fc2d612670
4 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/requirements.txt
View File

@ -1,6 +1,3 @@
# The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
sphinx>=2.0.0,!=2.1.0 # BSD
openstackdocstheme>=2.2.0 # Apache-2.0
reno>=3.1.0 # Apache-2.0

6
requirements.txt
View File

@ -1,10 +1,6 @@
# Requirements lower bounds listed here are our best effort to keep them up to
# date but we do not test them so no guarantee of having them all correct. If
# you find any incorrect lower bounds, let us know or propose a fix.
# The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
# you find any incorrect lower bounds, let us know or propose a fix.
pbr>=3.1.1 # Apache-2.0
cliff!=2.9.0,>=2.8.0 # Apache-2.0

6
test-requirements.txt
View File

@ -1,8 +1,4 @@
# The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
hacking>=3.0.1,<3.1.0 # Apache-2.0
hacking>=7.0.0,<7.1.0 # Apache-2.0
coverage>=4.5.1 # Apache-2.0
python-subunit>=1.2.0 # Apache-2.0/BSD
oslotest>=3.3.0 # Apache-2.0

4
vitrageclient/common/formatters.py
View File

@ -73,9 +73,9 @@ class GraphFormatter(base.SingleFormatter, metaclass=abc.ABCMeta):
@staticmethod
def _list2str(node):
for k, v in node.items():
if type(v) == list:
if type(v) is list:
node[k] = str(v)
if type(v) == str and ":" in v:
if type(v) is str and ":" in v:
node[k] = '"' + v + '"'
@abc.abstractmethod