openstack/python-zaqarclient
Code Issues Proposed changes

Fixing the deprecated library function

Browse Source 
os.popen() is deprecated since version 2.6. Resolved with use
of subprocess module.

Change-Id: I71241cc8d47d1be4dcb20924937cb1c25afbc240
Partial-Bug: #1529836
This commit is contained in:
MD NADEEM
2016-01-12 11:32:40 +05:30
committed by MD NADEEM
parent 4d48c7e9d9
commit e97a78387b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
doc/source/conf.py
View File

@@ -14,6 +14,7 @@
import sys import sys
import os import os
import subprocess
# If extensions (or modules to document with autodoc) are in another directory, # If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the # add these directories to sys.path here. If the directory is relative to the
@@ -159,9 +160,10 @@ html_static_path = []
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom, # If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format. # using the given strftime format.
#html_last_updated_fmt = '%b %d, %Y' #html_last_updated_fmt = '%b %d, %Y'
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1" git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'",
html_last_updated_fmt = os.popen(git_cmd).read() "--date=local", "-n1"]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to # If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities. # typographically correct entities.
#html_use_smartypants = True #html_use_smartypants = True