Update patch set 5

Patch Set 5: Code-Review+1

(5 comments)

LGTM except for the URL. And how about adding the URL for whitebox tempest plugin's repo to this spec and/or in the commit message as a reference?

 https://opendev.org/x/whitebox-tempest-plugin

Patch-set: 5
Label: Code-Review=+1
This commit is contained in:
Gerrit User 5689 2020-03-04 23:27:35 +00:00 committed by Gerrit Code Review
parent 4159d25058
commit 231492f611
1 changed files with 113 additions and 0 deletions

View File

@ -0,0 +1,113 @@
{
"comments": [
{
"key": {
"uuid": "1fa4df85_0302e53d",
"filename": "specs/other/whitebox-tempest-plugin.rst",
"patchSetId": 5
},
"lineNbr": 12,
"author": {
"id": 5689
},
"writtenOn": "2020-03-04T23:27:35Z",
"side": 1,
"message": "Is this URL is correct? This doesn\u0027t work for me.",
"revId": "69a6bce70f61563fcf315fabd1db52965558c5e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1fa4df85_f6dae575",
"filename": "specs/other/whitebox-tempest-plugin.rst",
"patchSetId": 5
},
"lineNbr": 48,
"author": {
"id": 5689
},
"writtenOn": "2020-03-04T23:27:35Z",
"side": 1,
"message": "exist?",
"range": {
"startLine": 48,
"startChar": 64,
"endLine": 48,
"endChar": 70
},
"revId": "69a6bce70f61563fcf315fabd1db52965558c5e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1fa4df85_b65d4d16",
"filename": "specs/other/whitebox-tempest-plugin.rst",
"patchSetId": 5
},
"lineNbr": 77,
"author": {
"id": 5689
},
"writtenOn": "2020-03-04T23:27:35Z",
"side": 1,
"message": "This \"_\" isn\u0027t necessary. I guess the HTML rendering is a bit weird.\nhttps://9abde9dfbceba4b989ea-cd725815d30cf2ab8520aad695ae6c76.ssl.cf1.rackcdn.com/656890/5/check/openstack-tox-docs/1b26d5e/docs/specs/other/whitebox-tempest-plugin.html#references",
"range": {
"startLine": 77,
"startChar": 66,
"endLine": 77,
"endChar": 67
},
"revId": "69a6bce70f61563fcf315fabd1db52965558c5e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1fa4df85_76a115f8",
"filename": "specs/other/whitebox-tempest-plugin.rst",
"patchSetId": 5
},
"lineNbr": 80,
"author": {
"id": 5689
},
"writtenOn": "2020-03-04T23:27:35Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 80,
"startChar": 56,
"endLine": 80,
"endChar": 57
},
"revId": "69a6bce70f61563fcf315fabd1db52965558c5e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1fa4df85_16a221fd",
"filename": "specs/other/whitebox-tempest-plugin.rst",
"patchSetId": 5
},
"lineNbr": 89,
"author": {
"id": 5689
},
"writtenOn": "2020-03-04T23:27:35Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 89,
"startChar": 78,
"endLine": 89,
"endChar": 79
},
"revId": "69a6bce70f61563fcf315fabd1db52965558c5e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}