openstack/qa-specs
Code Issues Proposed changes

Show line number in error message

Browse Source 
Also fix pep8 issues.

Change-Id: I064886c36a9ac2cc7c659f8b1650ce6c9e817ec2
This commit is contained in:
David Kranz 2014-04-11 13:39:54 -04:00
parent 0d26b5f41c
commit e5dd061d63
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/rstcheck.py
View File

@ -23,11 +23,13 @@ import sys
ERRORS = 0
def error(msg):
global ERRORS
ERRORS += 1
print(msg)
def get_options():
parser = argparse.ArgumentParser(
description='RST sanity checker')
@ -35,6 +37,7 @@ def get_options():
default="specs")
return parser.parse_args()
def find_rst_files(dirname):
files = []
for root, dirnames, filenames in os.walk(dirname):
@ -43,16 +46,20 @@ def find_rst_files(dirname):
files.append("%s/%s" % (root, f))
return files
def ensure_files_end_in_rst(files):
for fname in files:
if not re.search("\.rst$", fname):
error("E001: Filename %s does not end in .rst" % fname)
def ensure_lt80(files):
for fname in files:
for line in fileinput.input(fname):
if len(line) > 80:
error("E002: File %s exceeds 80 columns" % fname)
i = fileinput.lineno()
error("E002: File %s:%s exceeds 80 columns" % (fname, i))
def main():
opts = get_options()