Update patch set 6

Patch Set 6: Code-Review-1

(3 comments)

I like the idea and this is really cool.

Few more details we need to add, comment inline. Thanks.

Patch-set: 6
Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 8556 2019-08-14 23:27:30 +00:00 committed by Gerrit Code Review
parent d64580b111
commit ed9b056efa
1 changed files with 73 additions and 0 deletions

View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "7faddb67_dd35ac46",
"filename": "specs/tempest/account-gen-refactor.rst",
"patchSetId": 6
},
"lineNbr": 46,
"author": {
"id": 8556
},
"writtenOn": "2019-08-14T23:27:30Z",
"side": 1,
"message": "+1.",
"range": {
"startLine": 45,
"startChar": 0,
"endLine": 46,
"endChar": 11
},
"revId": "273336fc796cf342b47f8efa11c095bde7c21bb2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_fd13c8b6",
"filename": "specs/tempest/account-gen-refactor.rst",
"patchSetId": 6
},
"lineNbr": 49,
"author": {
"id": 8556
},
"writtenOn": "2019-08-14T23:27:30Z",
"side": 1,
"message": "is this mean the input file will have the resource UUID/name etc and account-gen will create those resources? like I am telling what all resource account-gen should create ?",
"range": {
"startLine": 48,
"startChar": 2,
"endLine": 49,
"endChar": 86
},
"revId": "273336fc796cf342b47f8efa11c095bde7c21bb2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_9d3bb436",
"filename": "specs/tempest/account-gen-refactor.rst",
"patchSetId": 6
},
"lineNbr": 51,
"author": {
"id": 8556
},
"writtenOn": "2019-08-14T23:27:30Z",
"side": 1,
"message": "this is really nice. What all verification will be done in this step ? only file exist or resource are valid or not etc also ?",
"range": {
"startLine": 51,
"startChar": 0,
"endLine": 51,
"endChar": 72
},
"revId": "273336fc796cf342b47f8efa11c095bde7c21bb2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}