Update patch set 4

Patch Set 4: Code-Review-1 (3 comments) Patch-set: 4 Label: Code-Review=-1
2019-08-06 03:57:10 +00:00 · 2019-08-06 03:57:10 +00:00 · 4092eacfb2
parent c082d5e738
commit 4092eacfb2
1 changed files with 73 additions and 0 deletions
--- a/73
+++ b/73
@ -0,0 +1,73 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "7faddb67_bc6df503",
+        "filename": "qinling/api/controllers/v1/execution.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 86,
+      "author": {
+        "id": 6732
+      },
+      "writtenOn": "2019-08-06T03:57:10Z",
+      "side": 1,
+      "message": "I think all the logic here are already covered in executions.create_execution() function.",
+      "range": {
+        "startLine": 71,
+        "startChar": 0,
+        "endLine": 86,
+        "endChar": 75
+      },
+      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_7c73fde7",
+        "filename": "qinling/db/sqlalchemy/models.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 55,
+      "author": {
+        "id": 6732
+      },
+      "writtenOn": "2019-08-06T03:57:10Z",
+      "side": 1,
+      "message": "I don\u0027t think we need to store function_alias for the execution, an execution should be specific to a function_id and version, even it\u0027s created using function_alias.",
+      "range": {
+        "startLine": 55,
+        "startChar": 4,
+        "endLine": 55,
+        "endChar": 18
+      },
+      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7faddb67_dc4d519a",
+        "filename": "qinling/db/sqlalchemy/models.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 95,
+      "author": {
+        "id": 6732
+      },
+      "writtenOn": "2019-08-06T03:57:10Z",
+      "side": 1,
+      "message": "We also need to change the logic that when a webhook is triggered, function_alias needs to translate into the function id and version.",
+      "range": {
+        "startLine": 95,
+        "startChar": 4,
+        "endLine": 95,
+        "endChar": 18
+      },
+      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}