From 49c4c10adb99d3ce9002470084be7a3f07885b00 Mon Sep 17 00:00:00 2001 From: Lingxian Kong Date: Wed, 26 Jul 2017 17:01:36 +1200 Subject: [PATCH] Fix a bug in job periodic task Change-Id: I4c26e08e3738023b1a7e7e8f0f2c1f59d7e80d79 --- qinling/db/sqlalchemy/api.py | 3 ++- qinling/services/periodics.py | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qinling/db/sqlalchemy/api.py b/qinling/db/sqlalchemy/api.py index 6a45c64c..5624660d 100644 --- a/qinling/db/sqlalchemy/api.py +++ b/qinling/db/sqlalchemy/api.py @@ -193,8 +193,9 @@ def _delete_all(model, insecure=False, **kwargs): @db_base.session_aware() def conditional_update(model, values, expected_values, insecure=False, - filters={}, session=None): + filters=None, session=None): """Compare-and-swap conditional update SQLAlchemy implementation.""" + filters = filters or {} filters.update(expected_values) query = (db_base.model_query(model) if insecure else _secure_query(model)) query = db_filters.apply_filters(query, model, **filters) diff --git a/qinling/services/periodics.py b/qinling/services/periodics.py index 3bb11f28..7a11a8b8 100644 --- a/qinling/services/periodics.py +++ b/qinling/services/periodics.py @@ -88,7 +88,6 @@ def handle_job(engine_client): models.Job, { 'status': status.DONE, - 'trust_id': '', 'count': 0 }, {