openstack
/
qinling
Code Issues Proposed changes

Fix date format to be compliant with UTC 

Currently the created_at and updated_at format is not
compliant with UTC.

  "created_at": "2019-06-11 00:16:54",
  "updated_at": "2019-06-11 00:17:33",

Should be:

  "created_at": "2019-06-11T00:16:54Z",
  "updated_at": "2019-06-11T00:17:33Z",

Change-Id: I000c67a542b52602927fd802d2e347847f8dcc12
Story: 2005854
Task: 33647
This commit is contained in:
Gaëtan Trellu 2019-06-10 23:02:06 -04:00
parent e18f80345a
commit 9a4a8ef978
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
qinling/db/sqlalchemy/model_base.py
View File

@ -85,7 +85,6 @@ class _QinlingModelBase(oslo_models.ModelBase, oslo_models.TimestampMixin):
updated_at = getattr(self, 'updated_at')
if updated_at:
setattr(m, 'updated_at', updated_at.isoformat(' '))
return m
def __repr__(self):

9
qinling/tests/unit/api/controllers/v1/test_job.py
View File

@ -217,9 +217,12 @@ class TestJobController(base.APITest):
count=10
).id
next_hour_and_half = datetime.utcnow() + timedelta(hours=1.5)
next_two_hours = datetime.utcnow() + timedelta(hours=2)
req_body = {
'next_execution_time': str(
datetime.utcnow() + timedelta(hours=1.5)
next_hour_and_half.strftime('%Y-%m-%dT%H:%M:%SZ')
),
'pattern': '1 */1 * * *'
}
@ -239,7 +242,9 @@ class TestJobController(base.APITest):
req_body = {
'status': status.RUNNING,
'next_execution_time': str(datetime.utcnow() + timedelta(hours=2)),
'next_execution_time': str(
next_two_hours.strftime('%Y-%m-%dT%H:%M:%SZ')
),
}
resp = self.app.put_json('/v1/jobs/%s' % job_id, req_body)

2
qinling/utils/common.py
View File

@ -85,7 +85,7 @@ def datetime_to_str(dct, attr_name):
"""Convert datetime object in dict to string."""
if (dct.get(attr_name) is not None and
not isinstance(dct.get(attr_name), six.string_types)):
dct[attr_name] = dct[attr_name].isoformat(' ')
dct[attr_name] = dct[attr_name].strftime('%Y-%m-%dT%H:%M:%SZ')
def generate_unicode_uuid(dashed=True):