qinling/b4666c3b9c753f1486b50cd30e2168b2bf8f22d7

{
  "comments": [
    {
      "key": {
        "uuid": "7faddb67_bc6df503",
        "filename": "qinling/api/controllers/v1/execution.py",
        "patchSetId": 4
      },
      "lineNbr": 86,
      "author": {
        "id": 6732
      },
      "writtenOn": "2019-08-06T03:57:10Z",
      "side": 1,
      "message": "I think all the logic here are already covered in executions.create_execution() function.",
      "range": {
        "startLine": 71,
        "startChar": 0,
        "endLine": 86,
        "endChar": 75
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_ce9fccb1",
        "filename": "qinling/api/controllers/v1/execution.py",
        "patchSetId": 4
      },
      "lineNbr": 86,
      "author": {
        "id": 16006
      },
      "writtenOn": "2019-08-06T13:23:24Z",
      "side": 1,
      "message": "You\u0027re right but it didn\u0027t seem to work as expected.\nI found why, \u0027version\u0027 should be \u0027function_version\u0027[1].\n\nhttps://github.com/openstack/qinling/blob/master/qinling/utils/executions.py#L83",
      "parentUuid": "7faddb67_bc6df503",
      "range": {
        "startLine": 71,
        "startChar": 0,
        "endLine": 86,
        "endChar": 75
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_7c73fde7",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 55,
      "author": {
        "id": 6732
      },
      "writtenOn": "2019-08-06T03:57:10Z",
      "side": 1,
      "message": "I don\u0027t think we need to store function_alias for the execution, an execution should be specific to a function_id and version, even it\u0027s created using function_alias.",
      "range": {
        "startLine": 55,
        "startChar": 4,
        "endLine": 55,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_0ebe44ad",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 55,
      "author": {
        "id": 16006
      },
      "writtenOn": "2019-08-06T13:23:24Z",
      "side": 1,
      "message": "I understand your point but I think it could be useful to know how the execution has been triggered for debug reasons for example.\n\nIf someone in their code forget to update the alias and trigger the execution with a deprecated function version then it will be simplest to track it.",
      "parentUuid": "7faddb67_7c73fde7",
      "range": {
        "startLine": 55,
        "startChar": 4,
        "endLine": 55,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_d59f464f",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 55,
      "author": {
        "id": 6732
      },
      "writtenOn": "2019-08-07T11:17:17Z",
      "side": 1,
      "message": "OK, fair enough",
      "parentUuid": "7faddb67_0ebe44ad",
      "range": {
        "startLine": 55,
        "startChar": 4,
        "endLine": 55,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_dc4d519a",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 95,
      "author": {
        "id": 6732
      },
      "writtenOn": "2019-08-06T03:57:10Z",
      "side": 1,
      "message": "We also need to change the logic that when a webhook is triggered, function_alias needs to translate into the function id and version.",
      "range": {
        "startLine": 95,
        "startChar": 4,
        "endLine": 95,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_b5a64aab",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 95,
      "author": {
        "id": 6732
      },
      "writtenOn": "2019-08-07T11:17:17Z",
      "side": 1,
      "message": "The invoke() function in WebhooksController should also be changed.",
      "parentUuid": "7faddb67_dc4d519a",
      "range": {
        "startLine": 95,
        "startChar": 4,
        "endLine": 95,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_aded9ef1",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 95,
      "author": {
        "id": 16006
      },
      "writtenOn": "2019-08-07T13:42:59Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "7faddb67_b5a64aab",
      "range": {
        "startLine": 95,
        "startChar": 4,
        "endLine": 95,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7faddb67_4ddf4a3a",
        "filename": "qinling/db/sqlalchemy/models.py",
        "patchSetId": 4
      },
      "lineNbr": 95,
      "author": {
        "id": 16006
      },
      "writtenOn": "2019-08-07T13:42:59Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "7faddb67_dc4d519a",
      "range": {
        "startLine": 95,
        "startChar": 4,
        "endLine": 95,
        "endChar": 18
      },
      "revId": "b4666c3b9c753f1486b50cd30e2168b2bf8f22d7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}