From 65fedb1a0b227cccf124c3bb71cbec74fe405ebf Mon Sep 17 00:00:00 2001 From: Yatin Kumbhare Date: Wed, 6 Jan 2016 15:24:50 +0530 Subject: [PATCH] Use assertTrue/False instead of assertEqual(T/F) The usage of assertEqual(True/False, ***) should be changed to a meaningful format of assertTrue/False(***). Change-Id: Ic07f2cbbbcabff1a5b6940f56521fda582b128a5 Closes-Bug: #1512207 --- .../openstack/context/manila/test_manila_share_networks.py | 2 +- .../plugins/openstack/context/sahara/test_sahara_image.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/plugins/openstack/context/manila/test_manila_share_networks.py b/tests/unit/plugins/openstack/context/manila/test_manila_share_networks.py index e5eb470b..5f0ce434 100644 --- a/tests/unit/plugins/openstack/context/manila/test_manila_share_networks.py +++ b/tests/unit/plugins/openstack/context/manila/test_manila_share_networks.py @@ -74,7 +74,7 @@ class ManilaSampleGeneratorTestCase(test.TestCase): inst.config) self.assertIn( rally_consts.JSON_SCHEMA, inst.CONFIG_SCHEMA.get("$schema")) - self.assertEqual(False, inst.CONFIG_SCHEMA.get("additionalProperties")) + self.assertFalse(inst.CONFIG_SCHEMA.get("additionalProperties")) self.assertEqual("object", inst.CONFIG_SCHEMA.get("type")) props = inst.CONFIG_SCHEMA.get("properties", {}) self.assertEqual({"type": "object"}, props.get("share_networks")) diff --git a/tests/unit/plugins/openstack/context/sahara/test_sahara_image.py b/tests/unit/plugins/openstack/context/sahara/test_sahara_image.py index ea1d051c..6c912895 100644 --- a/tests/unit/plugins/openstack/context/sahara/test_sahara_image.py +++ b/tests/unit/plugins/openstack/context/sahara/test_sahara_image.py @@ -145,10 +145,10 @@ class SaharaImageTestCase(test.ScenarioTestCase): sahara_ctx.context["tenants"][tenant_id]["sahara"]["image"]) self.assertEqual("some_id", image_id) - self.assertEqual(False, mock_glance_scenario__create_image.called) + self.assertFalse(mock_glance_scenario__create_image.called) sahara_ctx.cleanup() - self.assertEqual(False, mock_cleanup.called) + self.assertFalse(mock_cleanup.called) @mock.patch("%s.osclients.Glance.create_client" % CTX) def test_check_existing_image(self, mock_glance_create_client):