Merge "Pass insecure to manila client"

CHANGELOG.rst

@@ -59,9 +59,10 @@ Changed
 Fixed
 ~~~~~
 
-* Do not ignore ``region_name`` from environment specification while
+* Ignoring ``region_name`` from environment specification while
   initializing keystone client.
 * Fetching OSProfiler trace-info for some drivers.
+* ``https_insecure`` is not passed to manilaclient
 
 [1.3.0] - 2018-10-08
 --------------------

rally_openstack/osclients.py

@@ -547,6 +547,7 @@ class Manila(OSClient):
         from manilaclient import client as manila
         manila_client = manila.Client(
             self.choose_version(version),
+            insecure=self.credential.https_insecure,
             session=self.keystone.get_session()[0],
             service_catalog_url=self._get_endpoint(service_type))
         return manila_client

tests/unit/test_osclients.py

@@ -659,6 +659,7 @@ class OSClientsTestCase(test.TestCase):
             client = self.clients.manila()
             self.assertEqual(mock_manila.client.Client.return_value, client)
             kw = {
+                "insecure": False,
                 "session": mock_keystoneauth1.session.Session(),
                 "service_catalog_url": mock_manila__get_endpoint.return_value
             }