openstack/rally
Code Issues Proposed changes

Merge "Add functional tests to task detailed with errors"

Browse Source
This commit is contained in:
Jenkins 2016-04-12 12:14:02 +00:00 committed by Gerrit Code Review
commit 37ffd64fb1
2 changed files with 22 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/functional/test_cli_task.py
View File

@ -124,6 +124,26 @@ class TaskTestCase(unittest.TestCase):
self.assertIn("2. dummy_fail_test (2)", detailed_iterations_data)
self.assertNotIn("n/a", detailed_iterations_data)
def test_detailed_with_errors(self):
rally = utils.Rally()
cfg = {
"Dummy.dummy_exception": [
{
"runner": {
"type": "constant",
"times": 1,
"concurrency": 1
}
}
]
}
config = utils.TaskConfig(cfg)
output = rally("task start --task %s" % config.filename)
uuid = re.search(
r"(?P<uuid>[0-9a-f\-]{36}): started", output).group("uuid")
output = rally("task detailed")
self.assertIn("Task %s has 1 error(s)" % uuid, output)
def test_detailed_no_atomic_actions(self):
rally = utils.Rally()
cfg = {

37
tests/unit/cli/commands/test_task.py
View File

@ -20,7 +20,6 @@ import os.path
import ddt
import mock
from rally.cli import cliutils
from rally.cli.commands import task
from rally import consts
from rally import exceptions
@ -825,38 +824,6 @@ class TaskCommandsTestCase(test.TestCase):
self.task.detailed(test_uuid)
mock_task.get_detailed.assert_called_once_with(test_uuid,
extended_results=True)
err_report = "%(error_type)s: %(error_message)s\n" % (
{"error_type": error_type, "error_message": error_message})
header = cliutils.make_header("Task %s has %d error(s)" %
(test_uuid, 1))
mock_stdout.write.assert_has_calls([
mock.call("\n"), mock.call("-" * 80), mock.call("\n"),
mock.call("Task test_task_id: status"),
mock.call("\n"), mock.call("-" * 80), mock.call("\n"),
mock.call("\n"), mock.call("test scenario fake_name"),
mock.call("\n"), mock.call("args position fake_pos"),
mock.call("\n"), mock.call("args values:"),
mock.call("\n"), mock.call("\"fake_kw\""),
mock.call("\n"), mock.call("\n"),
mock.call(header), mock.call("\n"),
mock.call(err_report), mock.call("\n"),
mock.call(error_traceback or "No traceback available."),
mock.call("\n"), mock.call("-" * 80), mock.call("\n"),
mock.call("\n"), mock.call("Load duration: 3.2"),
mock.call("\n"), mock.call("Full duration: 3.5"),
mock.call("\n"), mock.call("\nHINTS:"),
mock.call("\n"),
mock.call("* To plot HTML graphics with this data, run:"),
mock.call("\n"),
mock.call("\trally task report test_task_id --out output.html\n"),
mock.call("\n"), mock.call("* To generate a JUnit report, run:"),
mock.call("\n"),
mock.call("\trally task report test_task_id "
"--junit --out output.xml\n"),
mock.call("\n"),
mock.call("* To get raw JSON output of task results, run:"),
mock.call("\n"),
mock.call("\trally task results test_task_id\n"),
mock.call("\n")
])
mock.call(error_traceback or "No traceback available.")
], any_order=False)