From 7bd24f74e72918c530e4442d855bda233597136e Mon Sep 17 00:00:00 2001
From: Hugh Saunders <hugh@wherenow.org>
Date: Wed, 5 Feb 2014 15:40:35 +0000
Subject: [PATCH] Mark task as failed if benchmark validation fails

Closes-Bug: #1276826
Change-Id: Idab924ab51cdd30c232b620abf161af40f3e4ac2
---
 rally/benchmark/engine.py      | 1 +
 tests/benchmark/test_engine.py | 1 +
 2 files changed, 2 insertions(+)

diff --git a/rally/benchmark/engine.py b/rally/benchmark/engine.py
index a069f516bc..c41e4afaf8 100644
--- a/rally/benchmark/engine.py
+++ b/rally/benchmark/engine.py
@@ -146,6 +146,7 @@ class TestEngine(object):
                                                    "validation":
                                                    {"is_valid": False,
                                                     "exc_msg": e.message}})
+                    self.task.set_failed()
                     LOG.error(_("Scenario (%(pos)s, %(name)s) input arguments "
                                 "validation error: %(msg)s") %
                               {"pos": n, "name": name, "msg": e.message})
diff --git a/tests/benchmark/test_engine.py b/tests/benchmark/test_engine.py
index 1bebc58bbc..da335c18cc 100644
--- a/tests/benchmark/test_engine.py
+++ b/tests/benchmark/test_engine.py
@@ -194,6 +194,7 @@ class TestEngineTestCase(test.TestCase):
                                      {'raw': [],
                                       'validation': {'is_valid': False,
                                       'exc_msg': validation_exc.message}}),
+            mock.call.set_failed(),
             mock.call.update_status(s.FINISHED)
         ]
         # NOTE(msdubov): Ignore task['uuid'] calls which are used for logging