From 8ea4e7100c13c7242094c730fb0da1f0f18e3260 Mon Sep 17 00:00:00 2001 From: Prabhjyot Singh Sodhi Date: Fri, 16 Jan 2015 05:37:28 -0800 Subject: [PATCH] Adding duration header to rally verify list query A new duration column is added to the result of "rally verify list" query It depicts the time for which the verification ran Change-Id: I6027634425ffd9b4e4217fda692dcc3972518360 --- rally/cmd/commands/verify.py | 6 +++++- tests/unit/cmd/commands/test_verify.py | 11 +++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/rally/cmd/commands/verify.py b/rally/cmd/commands/verify.py index d11a5bfe42..d181ec2f91 100644 --- a/rally/cmd/commands/verify.py +++ b/rally/cmd/commands/verify.py @@ -86,8 +86,12 @@ class VerifyCommands(object): """Display all verifications table, started and finished.""" fields = ["UUID", "Deployment UUID", "Set name", "Tests", "Failures", - "Created at", "Status"] + "Created at", "Duration", "Status"] verifications = db.verification_list() + + for el in verifications: + el["duration"] = el["updated_at"] - el["created_at"] + if verifications: common_cliutils.print_list(verifications, fields, sortby_index=fields.index("Created at")) diff --git a/tests/unit/cmd/commands/test_verify.py b/tests/unit/cmd/commands/test_verify.py index 53909550c4..33497f7cee 100644 --- a/tests/unit/cmd/commands/test_verify.py +++ b/tests/unit/cmd/commands/test_verify.py @@ -13,6 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. +import datetime as date import tempfile import mock @@ -96,10 +97,16 @@ class VerifyCommandsTestCase(test.TestCase): @mock.patch("rally.db.verification_list") def test_list(self, mock_db_verification_list, mock_print_list): fields = ["UUID", "Deployment UUID", "Set name", "Tests", "Failures", - "Created at", "Status"] - verifications = {"dummy": []} + "Created at", "Duration", "Status"] + verifications = [{"created_at": date.datetime.now(), + "updated_at": date.datetime.now()}] mock_db_verification_list.return_value = verifications self.verify.list() + + for row in verifications: + self.assertEqual(row["updated_at"] - row["created_at"], + row["duration"]) + mock_db_verification_list.assert_called_once_with() mock_print_list.assert_called_once_with(verifications, fields, sortby_index=fields.index(