openstack/rally
Code Issues Proposed changes

Fix VM provider get_available_providers() test

Browse Source 
Fix VM provider get_available_providers() to be able to add new
providers without changing it.

Change-Id: I01167cfe21a2ff5e74bf875649273fef4aa1df03
This commit is contained in:
Boris Pavlovic
2013-09-11 10:47:02 +04:00
parent 250bf18dbc
commit a562a39536
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/vmprovider/test_vm_provider.py
View File

@@ -64,10 +64,11 @@ class VMProviderTestCase(test.NoDBTestCase):
# TODO(boris-42): make it work through assertIsInstance
self.assertEqual(str(type(p_inst)), str(p))
def test_get_all_provider(self):
provider = [p.__name__ for p in self._create_fake_providers()]
real_provider = vmprovider.VMProviderFactory.get_available_providers()
self.assertEqual(sorted(provider), sorted(real_provider))
def test_get_available_providers(self):
providers = set([p.__name__ for p in self._create_fake_providers()])
real_providers = \
set(vmprovider.VMProviderFactory.get_available_providers())
self.assertEqual(providers & real_providers, providers)
def test_vm_prvoider_factory_is_abstract(self):
self.assertRaises(TypeError, vmprovider.VMProviderFactory)