From d04111628bfae08c51d2117651abc9de43f3b932 Mon Sep 17 00:00:00 2001 From: chen-li Date: Tue, 22 Apr 2014 15:47:54 +0800 Subject: [PATCH] Use "https" instead of "git" for cloning code If you're in a private network, you need to setup a proxy to access the public network. It would be a difficult thing to set-up proxy for git:// protocol, while much more easy to use https:// protocol instead. Change-Id: Iec8447cc28760a98e1641162c50c152c89100775 --- rally/deploy/engines/devstack.py | 2 +- rally/verification/verifiers/tempest/tempest.py | 2 +- tests/verification/verifiers/test_tempest.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rally/deploy/engines/devstack.py b/rally/deploy/engines/devstack.py index 7aa5a1c0cc..c336886c72 100644 --- a/rally/deploy/engines/devstack.py +++ b/rally/deploy/engines/devstack.py @@ -47,7 +47,7 @@ class DevstackEngine(engine.EngineFactory): Sample of a configuration: { "type": "DevstackEngine", - "devstack_repo": "git://example.com/devstack/", + "devstack_repo": "https://example.com/devstack/", "localrc": { "ADMIN_PASSWORD": "secret" }, diff --git a/rally/verification/verifiers/tempest/tempest.py b/rally/verification/verifiers/tempest/tempest.py index a7d1563353..40fd029203 100644 --- a/rally/verification/verifiers/tempest/tempest.py +++ b/rally/verification/verifiers/tempest/tempest.py @@ -115,7 +115,7 @@ class Tempest(object): print("Please wait while tempest is being cloned. " "This could take a few minutes...") subprocess.check_call(["git", "clone", - "git://github.com/openstack/tempest", + "https://github.com/openstack/tempest", Tempest.tempest_base_path]) def install(self): diff --git a/tests/verification/verifiers/test_tempest.py b/tests/verification/verifiers/test_tempest.py index e46679c75f..df6ab2ad51 100644 --- a/tests/verification/verifiers/test_tempest.py +++ b/tests/verification/verifiers/test_tempest.py @@ -59,7 +59,7 @@ class TempestTestCase(test.TestCase): def test__clone(self, mock_sp): self.verifier._clone() mock_sp.check_call.assert_called_once_with( - ['git', 'clone', 'git://github.com/openstack/tempest', + ['git', 'clone', 'https://github.com/openstack/tempest', tempest.Tempest.tempest_base_path]) @mock.patch(TEMPEST_PATH + '.tempest.Tempest._initialize_testr')