openstack/rally
Code Issues Proposed changes

Use "https" instead of "git" for cloning code

Browse Source 
If you're in a private network, you need to setup a proxy
to access the public network. It would be a difficult thing
to set-up proxy for git:// protocol, while much more easy to
use https:// protocol instead.

Change-Id: Iec8447cc28760a98e1641162c50c152c89100775
This commit is contained in:
chen-li 2014-04-22 15:47:54 +08:00
parent 8c77a27fef
commit d04111628b
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rally/deploy/engines/devstack.py
View File

@ -47,7 +47,7 @@ class DevstackEngine(engine.EngineFactory):
Sample of a configuration: Sample of a configuration:
{ {
"type": "DevstackEngine", "type": "DevstackEngine",
"devstack_repo": "git://example.com/devstack/", "devstack_repo": "https://example.com/devstack/",
"localrc": { "localrc": {
"ADMIN_PASSWORD": "secret" "ADMIN_PASSWORD": "secret"
}, },

2
rally/verification/verifiers/tempest/tempest.py
View File

@ -115,7 +115,7 @@ class Tempest(object):
print("Please wait while tempest is being cloned. " print("Please wait while tempest is being cloned. "
"This could take a few minutes...") "This could take a few minutes...")
subprocess.check_call(["git", "clone", subprocess.check_call(["git", "clone",
"git://github.com/openstack/tempest", "https://github.com/openstack/tempest",
Tempest.tempest_base_path]) Tempest.tempest_base_path])
def install(self): def install(self):

2
tests/verification/verifiers/test_tempest.py
View File

@ -59,7 +59,7 @@ class TempestTestCase(test.TestCase):
def test__clone(self, mock_sp): def test__clone(self, mock_sp):
self.verifier._clone() self.verifier._clone()
mock_sp.check_call.assert_called_once_with( mock_sp.check_call.assert_called_once_with(
['git', 'clone', 'git://github.com/openstack/tempest', ['git', 'clone', 'https://github.com/openstack/tempest',
tempest.Tempest.tempest_base_path]) tempest.Tempest.tempest_base_path])
@mock.patch(TEMPEST_PATH + '.tempest.Tempest._initialize_testr') @mock.patch(TEMPEST_PATH + '.tempest.Tempest._initialize_testr')