openstack/rally
Code Issues Proposed changes

Merge "Do not update the average when iteration failed"

Browse Source
This commit is contained in:
Jenkins
2015-06-16 14:11:04 +00:00
committed by Gerrit Code Review
parent 657717a5ea 72e573a1b0
commit f60e109d3a
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
rally/plugins/common/sla/max_average_duration.py
View File

@@ -21,6 +21,7 @@ with contracted values such as maximum error rate or minimum response time.
from rally.benchmark import sla from rally.benchmark import sla
from rally.common.i18n import _ from rally.common.i18n import _
from rally.common import streaming_algorithms
@sla.configure(name="max_avg_duration") @sla.configure(name="max_avg_duration")
@@ -31,15 +32,13 @@ class MaxAverageDuration(sla.SLA):
def __init__(self, criterion_value): def __init__(self, criterion_value):
super(MaxAverageDuration, self).__init__(criterion_value) super(MaxAverageDuration, self).__init__(criterion_value)
self.total_duration = 0.0
self.iterations = 0
self.avg = 0.0 self.avg = 0.0
self.avg_comp = streaming_algorithms.MeanStreamingComputation()
def add_iteration(self, iteration): def add_iteration(self, iteration):
if not iteration.get("error"): if not iteration.get("error"):
self.total_duration += iteration["duration"] self.avg_comp.add(iteration["duration"])
self.iterations += 1 self.avg = self.avg_comp.result()
self.avg = self.total_duration / self.iterations
self.success = self.avg <= self.criterion_value self.success = self.avg <= self.criterion_value
return self.success return self.success