
We rename several modules in the system (mostly in unit tests) so that their namings become consistent throughout the code. "Consistency" means here following certain rules like "name all deploy engine and server provider modules without _engine.py and _provider.py suffixes" or "name all unit tests like test_<tested_module>.py". We also add a couple of new folders in unit tests so that the unit tests structure strictly resembles that of tested modules. Blueprint unit-tests-refactoring Change-Id: Ia7b6afce0d1e20b969b56301e0c9ad0f94cc60e4
236 lines
7.8 KiB
Python
236 lines
7.8 KiB
Python
# Copyright 2013: Mirantis Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Test for deploy engines."""
|
|
|
|
import mock
|
|
import uuid
|
|
|
|
from rally import consts
|
|
from rally import deploy
|
|
from rally import exceptions
|
|
from rally import test
|
|
|
|
|
|
def make_fake_deployment(**kwargs):
|
|
values = dict({
|
|
'uuid': uuid.uuid4(),
|
|
'config': {
|
|
'name': 'fake',
|
|
},
|
|
'status': consts.DeployStatus.DEPLOY_INIT,
|
|
}, **kwargs)
|
|
return FakeDeployment(values=values)
|
|
|
|
|
|
class FakeDeployment(object):
|
|
|
|
def __init__(self, values={}):
|
|
self._values = values
|
|
|
|
def __getitem__(self, name):
|
|
return self._values[name]
|
|
|
|
def update_status(self, status):
|
|
pass
|
|
|
|
def set_started(self):
|
|
pass
|
|
|
|
def set_completed(self):
|
|
pass
|
|
|
|
def delete(self):
|
|
pass
|
|
|
|
|
|
class FakeEngine(deploy.EngineFactory):
|
|
deployed = False
|
|
cleanuped = False
|
|
|
|
def __init__(self, deployment):
|
|
super(FakeEngine, self).__init__(deployment)
|
|
self.deployment = deployment
|
|
|
|
def deploy(self):
|
|
self.deployed = True
|
|
return self
|
|
|
|
def cleanup(self):
|
|
self.cleanuped = True
|
|
|
|
|
|
class EngineMixIn(object):
|
|
def deploy(self):
|
|
pass
|
|
|
|
def cleanup(self):
|
|
pass
|
|
|
|
|
|
class EngineFake1(EngineMixIn, deploy.EngineFactory):
|
|
pass
|
|
|
|
|
|
class EngineFake2(EngineMixIn, deploy.EngineFactory):
|
|
pass
|
|
|
|
|
|
class EngineFake3(EngineFake2):
|
|
pass
|
|
|
|
|
|
class EngineFactoryTestCase(test.TestCase):
|
|
FAKE_ENGINES = [EngineFake1, EngineFake2, EngineFake3]
|
|
|
|
@mock.patch.object(FakeEngine, 'validate')
|
|
def test_init(self, fake_validate):
|
|
FakeEngine({'config': {}})
|
|
fake_validate.assert_called_once_with()
|
|
|
|
@mock.patch.object(FakeDeployment, 'update_status')
|
|
def test_get_engine_not_found(self, mock_update_status):
|
|
deployment = make_fake_deployment()
|
|
self.assertRaises(exceptions.NoSuchEngine,
|
|
deploy.EngineFactory.get_engine,
|
|
"non_existing_engine", deployment)
|
|
mock_update_status.assert_called_once_with(
|
|
consts.DeployStatus.DEPLOY_FAILED)
|
|
|
|
@mock.patch.object(FakeDeployment, 'set_completed')
|
|
@mock.patch.object(FakeDeployment, 'set_started')
|
|
def test_make_deploy(self, mock_set_started, mock_set_completed):
|
|
deployment = make_fake_deployment()
|
|
engine = FakeEngine(deployment)
|
|
endpoint = engine.make_deploy()
|
|
self.assertEqual(engine, endpoint)
|
|
self.assertTrue(endpoint.deployed)
|
|
self.assertFalse(endpoint.cleanuped)
|
|
mock_set_started.assert_called_once()
|
|
mock_set_completed.assert_called_once()
|
|
|
|
@mock.patch.object(FakeDeployment, 'set_started')
|
|
@mock.patch.object(FakeEngine, 'deploy')
|
|
def test_make_deploy_failed(self, mock_deploy, mock_set_started):
|
|
class DeployFailed(Exception):
|
|
pass
|
|
|
|
deployment = make_fake_deployment()
|
|
engine = FakeEngine(deployment)
|
|
mock_deploy.side_effect = DeployFailed()
|
|
self.assertRaises(DeployFailed, engine.make_deploy)
|
|
mock_set_started.assert_called_once()
|
|
|
|
@mock.patch.object(FakeDeployment, 'update_status')
|
|
def test_make_cleanup(self, mock_update_status):
|
|
deployment = make_fake_deployment()
|
|
engine = FakeEngine(deployment)
|
|
engine.make_cleanup()
|
|
self.assertTrue(engine.cleanuped)
|
|
self.assertFalse(engine.deployed)
|
|
mock_update_status.assert_has_calls([
|
|
mock.call(consts.DeployStatus.CLEANUP_STARTED),
|
|
mock.call(consts.DeployStatus.CLEANUP_FINISHED),
|
|
])
|
|
self.assertTrue(engine.cleanuped)
|
|
|
|
@mock.patch.object(FakeDeployment, 'update_status')
|
|
@mock.patch.object(FakeEngine, 'cleanup')
|
|
def test_make_cleanup_failed(self, mock_cleanup, mock_update_status):
|
|
class CleanUpFailed(Exception):
|
|
pass
|
|
|
|
deployment = make_fake_deployment()
|
|
engine = FakeEngine(deployment)
|
|
mock_cleanup.side_effect = CleanUpFailed()
|
|
self.assertRaises(CleanUpFailed, engine.make_cleanup)
|
|
mock_update_status.assert_has_calls([
|
|
mock.call(consts.DeployStatus.CLEANUP_STARTED),
|
|
])
|
|
self.assertFalse(engine.cleanuped)
|
|
|
|
@mock.patch.object(FakeDeployment, 'update_status')
|
|
def test_with_statement(self, mock_update_status):
|
|
deployment = make_fake_deployment()
|
|
engine = FakeEngine(deployment)
|
|
with engine as deployer:
|
|
self.assertEqual(engine, deployer)
|
|
self.assertFalse(mock_update_status.called)
|
|
self.assertFalse(engine.cleanuped)
|
|
self.assertFalse(engine.deployed)
|
|
|
|
def test_with_statement_failed_on_init(self):
|
|
self._assert_changed_status_on_error(
|
|
consts.DeployStatus.DEPLOY_INIT,
|
|
consts.DeployStatus.DEPLOY_FAILED)
|
|
|
|
def test_with_statement_failed_on_started(self):
|
|
self._assert_changed_status_on_error(
|
|
consts.DeployStatus.DEPLOY_STARTED,
|
|
consts.DeployStatus.DEPLOY_FAILED)
|
|
|
|
def test_with_statement_failed_on_finished(self):
|
|
self._assert_changed_status_on_error(
|
|
consts.DeployStatus.DEPLOY_FINISHED,
|
|
consts.DeployStatus.DEPLOY_INCONSISTENT)
|
|
|
|
def test_with_statement_failed_on_cleanup(self):
|
|
self._assert_changed_status_on_error(
|
|
consts.DeployStatus.CLEANUP_STARTED,
|
|
consts.DeployStatus.CLEANUP_FAILED)
|
|
|
|
@mock.patch.object(FakeDeployment, 'update_status')
|
|
def _assert_changed_status_on_error(self, initial, final,
|
|
mock_update_status):
|
|
# NOTE(akscram): The assertRaises of testtools can't be used as
|
|
# a context manager in python26:
|
|
# with self.assertRaises(SomeError):
|
|
# with engine as deployer:
|
|
# raise SomeError()
|
|
# instead of:
|
|
# self.assertRaises(SomeError,
|
|
# context_with_error,
|
|
# SomeError(), engine)
|
|
def context_with_error(error, manager):
|
|
with manager:
|
|
raise error
|
|
|
|
class SomeError(Exception):
|
|
pass
|
|
|
|
deployment = make_fake_deployment(status=initial)
|
|
engine = FakeEngine(deployment)
|
|
self.assertRaises(SomeError, context_with_error, SomeError(), engine)
|
|
mock_update_status.assert_called_once_with(final)
|
|
self.assertFalse(engine.cleanuped)
|
|
self.assertFalse(engine.deployed)
|
|
|
|
def test_get_engine(self):
|
|
deployment = make_fake_deployment()
|
|
engines = EngineFactoryTestCase.FAKE_ENGINES
|
|
for e in engines:
|
|
engine_inst = deploy.EngineFactory.get_engine(e.__name__,
|
|
deployment)
|
|
# TODO(boris-42): make it work through assertIsInstance
|
|
self.assertEqual(str(type(engine_inst)), str(e))
|
|
|
|
def test_get_available_engines(self):
|
|
engines = set([e.__name__ for e in EngineFactoryTestCase.FAKE_ENGINES])
|
|
real_engines = set(deploy.EngineFactory.get_available_engines())
|
|
self.assertEqual(engines & real_engines, engines)
|
|
|
|
def test_engine_factory_is_abstract(self):
|
|
self.assertRaises(TypeError, deploy.EngineFactory)
|