
* Remove semantic validation mechanism for context. We will use same approach as for current scenarios (via decorators) * Pass "deployment" instead of "tasks" to validators. This allow us to remove access to DB from validators + we can call validation without creating tasks * Add hacking rule to force using construction "from rally import objects" * Fix unit tests Change-Id: Ibf08183b28479cc49ab6adfd12298612f6b4397f
Rally Style Commandments
- Step 1: Read the OpenStack Style Commandments http://docs.openstack.org/developer/hacking/
- Step 2: Read on
Rally Specific Commandments
- * [N30x] - Reserved for rules related to
mock
library -
- [N301] - Ensure that
assert_*
methods frommock
library is used correctly - [N302] - Ensure that nonexistent "assert_called" is not used
- [N303] - Ensure that nonexistent "assert_called_once" is not used
- [N301] - Ensure that
- * [N310-N314] - Reserved for rules related to logging
-
- [N310] - Ensure that
rally.log
is used instead ofrally.openstack.common.log
- [N311] - Validate that debug level logs are not translated
- [N312] - Validate correctness of debug on check.
- [N310] - Ensure that
- * [N32x] - Reserved for rules related to assert* methods
-
- [N320] - Ensure that
assertTrue(isinstance(A, B))
is not used - [N321] - Ensure that
assertEqual(type(A), B)
is not used - [N322] - Ensure that
assertEqual(A, None)
andassertEqual(None, A)
are not used - [N323] - Ensure that
assertTrue/assertFalse(A in/not in B)
are not used with collection contents - [N324] - Ensure that
assertEqual(A in/not in B, True/False)
andassertEqual(True/False, A in/not in B)
are not used with collection contents
- [N320] - Ensure that
- * [N33x] - Reserved for rules related to Python 3 compatibility
-
- [N330] - Ensure that
dict.iteritems()
is not used - [N331] - Ensure that
basestring
is not used - [N332] - Ensure that
StringIO.StringIO
is not used
- [N330] - Ensure that
- [N340] - Ensure that we are importing always
from rally import objects