openstack/rally
Code Issues Proposed changes
a34b2d906a
rally/tests/hacking
History
Chris St. Pierre 1b842d8dd5 Eliminated string formatting with single mapping key 
This fixes a string formatting bug in Sahara utils, but also changes a
number of other string formatting instances, and adds a hacking rule,
N353, to hopefully avoid this sort of error in the future.

Change-Id: Ic67aa49024b3d3d8701a2dd23569990f34a9e25b
2015-06-10 09:51:27 -05:00
..
__init__.py Reorganize test module structure 2014-10-07 13:50:40 +00:00
checks.py Eliminated string formatting with single mapping key 2015-06-10 09:51:27 -05:00
README.rst Eliminated string formatting with single mapping key 2015-06-10 09:51:27 -05:00

README.rst

Rally Style Commandments

Rally Specific Commandments

* [N30x] - Reserved for rules related to mock library
  • [N301] - Ensure that assert_* methods from mock library is used correctly
  • [N302] - Ensure that nonexistent "assert_called" is not used
  • [N303] - Ensure that nonexistent "assert_called_once" is not used
* [N310-N314] - Reserved for rules related to logging
  • [N310] - Ensure that rally.common.log is used as logging module
  • [N311] - Validate that debug level logs are not translated
  • [N312] - Validate correctness of debug on check.
* [N32x] - Reserved for rules related to assert* methods
  • [N320] - Ensure that assertTrue(isinstance(A, B)) is not used
  • [N321] - Ensure that assertEqual(type(A), B) is not used
  • [N322] - Ensure that assertEqual(A, None) and assertEqual(None, A) are not used
  • [N323] - Ensure that assertTrue/assertFalse(A in/not in B) are not used with collection contents
  • [N324] - Ensure that assertEqual(A in/not in B, True/False) and assertEqual(True/False, A in/not in B) are not used with collection contents
  • [N340] - Ensure that we are importing always from rally import objects
  • [N341] - Ensure that we are importing oslo_xyz packages instead of deprecated oslo.xyz ones
  • [N350] - Ensure that single quotes are not used
  • [N351] - Ensure that data structs (i.e Lists and Dicts) are declared literally rather than using constructors
  • [N353] - Ensure that string formatting only uses a mapping if multiple mapping keys are used.