c800370cfd
Fixed issues: H202 assertRaises Exception too broad H305 imports not grouped correctly H307 like imports should be grouped together H405 multi line docstring summary not separated with an empty line H904 Wrap long lines in parentheses instead of a backslash E122 continuation line missing indentation or outdented E128 continuation line under-indented for visual indent E131 continuation line unaligned for hanging indent E251 unexpected spaces around keyword / parameter equals E265 block comment should start with '# ' Change-Id: Ia2b8994c58686e3570f303f0725a2850d6b36e47
384 lines
15 KiB
Python
384 lines
15 KiB
Python
# Copyright 2014: Mirantis Inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
|
|
from glanceclient import exc as glance_exc
|
|
import mock
|
|
from novaclient import exceptions as nova_exc
|
|
|
|
from rally.benchmark import validation
|
|
from rally.openstack.common.gettextutils import _
|
|
from tests import fakes
|
|
from tests import test
|
|
|
|
|
|
TEMPEST = "rally.verification.verifiers.tempest.tempest"
|
|
|
|
|
|
class ValidationUtilsTestCase(test.TestCase):
|
|
|
|
def test_add(self):
|
|
def test_validator():
|
|
pass
|
|
|
|
@validation.add(test_validator)
|
|
def test_function():
|
|
pass
|
|
|
|
validators = getattr(test_function, "validators")
|
|
self.assertEqual(len(validators), 1)
|
|
self.assertEqual(validators[0], test_validator)
|
|
|
|
def test_number_invalid(self):
|
|
validator = validation.number('param', 0, 10, nullable=False)
|
|
|
|
result = validator(param=-1)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator(param=11)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator(param="not an int")
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator(param=None)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator()
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator(param=-0.1)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
def test_number_integer_only(self):
|
|
validator = validation.number('param', 0, 10, nullable=False,
|
|
integer_only=True)
|
|
result = validator(param="5.0")
|
|
self.assertFalse(result.is_valid)
|
|
|
|
validator = validation.number('param', 0, 10, nullable=False,
|
|
integer_only=False)
|
|
result = validator(param="5.0")
|
|
self.assertTrue(result.is_valid)
|
|
|
|
def test_number_valid(self):
|
|
validator = validation.number('param', 0, 10, nullable=False)
|
|
|
|
result = validator(param=0)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
result = validator(param=10)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
result = validator(param=10.0)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
result = validator(param=5.6)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
def test_number_nullable(self):
|
|
validator = validation.number('param', 0, 10, nullable=True)
|
|
|
|
result = validator(param=None)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
result = validator()
|
|
self.assertTrue(result.is_valid)
|
|
|
|
result = validator(param=-1)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
result = validator(param=0)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
@mock.patch("os.access")
|
|
def test_file_exists(self, mock_access):
|
|
validator = validation.file_exists('param')
|
|
result = validator(param='/tmp/foo')
|
|
mock_access.assert_called_once_with('/tmp/foo', os.R_OK)
|
|
self.assertTrue(result.is_valid)
|
|
|
|
@mock.patch("os.access")
|
|
def test_file_exists_negative(self, mock_access):
|
|
validator = validation.file_exists('param')
|
|
mock_access.return_value = False
|
|
result = validator(param='/tmp/bah')
|
|
mock_access.assert_called_with('/tmp/bah', os.R_OK)
|
|
self.assertFalse(result.is_valid)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_exists(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
fakegclient.images.get = mock.MagicMock()
|
|
mock_osclients.glance.return_value = fakegclient
|
|
validator = validation.image_exists("image")
|
|
test_img_id = "test_image_id"
|
|
resource = {"id": test_img_id}
|
|
result = validator(clients=mock_osclients,
|
|
image=resource)
|
|
fakegclient.images.get.assert_called_once_with(image=test_img_id)
|
|
self.assertTrue(result.is_valid)
|
|
self.assertIsNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_exists_fail(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
fakegclient.images.get = mock.MagicMock()
|
|
fakegclient.images.get.side_effect = glance_exc.HTTPNotFound
|
|
mock_osclients.glance.return_value = fakegclient
|
|
validator = validation.image_exists("image")
|
|
test_img_id = "test_image_id"
|
|
resource = {"id": test_img_id}
|
|
result = validator(clients=mock_osclients,
|
|
image=resource)
|
|
fakegclient.images.get.assert_called_once_with(image=test_img_id)
|
|
self.assertFalse(result.is_valid)
|
|
self.assertIsNotNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_flavor_exists(self, mock_osclients):
|
|
fakenclient = fakes.FakeNovaClient()
|
|
fakenclient.flavors = mock.MagicMock()
|
|
mock_osclients.nova.return_value = fakenclient
|
|
validator = validation.flavor_exists("flavor")
|
|
test_flavor_id = 1
|
|
resource = {"id": test_flavor_id}
|
|
result = validator(clients=mock_osclients,
|
|
flavor=resource)
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=test_flavor_id)
|
|
self.assertTrue(result.is_valid)
|
|
self.assertIsNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_flavor_exists_fail(self, mock_osclients):
|
|
fakenclient = fakes.FakeNovaClient()
|
|
fakenclient.flavors = mock.MagicMock()
|
|
fakenclient.flavors.get.side_effect = nova_exc.NotFound(code=404)
|
|
mock_osclients.nova.return_value = fakenclient
|
|
validator = validation.flavor_exists("flavor")
|
|
test_flavor_id = 101
|
|
resource = {"id": test_flavor_id}
|
|
result = validator(clients=mock_osclients,
|
|
flavor=resource)
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=test_flavor_id)
|
|
self.assertFalse(result.is_valid)
|
|
self.assertIsNotNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_valid_on_flavor(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
image = fakes.FakeImage()
|
|
image.min_ram = 0
|
|
image.size = 0
|
|
image.min_disk = 0
|
|
fakegclient.images.get = mock.MagicMock(return_value=image)
|
|
mock_osclients.glance.return_value = fakegclient
|
|
|
|
fakenclient = fakes.FakeNovaClient()
|
|
flavor = fakes.FakeFlavor()
|
|
flavor.ram = 1
|
|
flavor.disk = 1
|
|
fakenclient.flavors.get = mock.MagicMock(return_value=flavor)
|
|
mock_osclients.nova.return_value = fakenclient
|
|
|
|
validator = validation.image_valid_on_flavor("flavor", "image")
|
|
|
|
result = validator(clients=mock_osclients,
|
|
flavor={"id": flavor.id},
|
|
image={"id": image.id})
|
|
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=flavor.id)
|
|
fakegclient.images.get.assert_called_once_with(image=image.id)
|
|
|
|
self.assertTrue(result.is_valid)
|
|
self.assertIsNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_valid_on_flavor_fail(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
image = fakes.FakeImage()
|
|
image.min_ram = 1
|
|
image.size = 1
|
|
image.min_disk = 1
|
|
fakegclient.images.get = mock.MagicMock(return_value=image)
|
|
mock_osclients.glance.return_value = fakegclient
|
|
|
|
fakenclient = fakes.FakeNovaClient()
|
|
flavor = fakes.FakeFlavor()
|
|
flavor.ram = 0
|
|
flavor.disk = 0
|
|
fakenclient.flavors.get = mock.MagicMock(return_value=flavor)
|
|
mock_osclients.nova.return_value = fakenclient
|
|
|
|
validator = validation.image_valid_on_flavor("flavor", "image")
|
|
|
|
result = validator(clients=mock_osclients,
|
|
flavor={"id": flavor.id},
|
|
image={"id": image.id})
|
|
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=flavor.id)
|
|
fakegclient.images.get.assert_called_once_with(image=image.id)
|
|
|
|
self.assertFalse(result.is_valid)
|
|
self.assertIsNotNone(result.msg)
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_valid_on_flavor_image_not_exist(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
fakegclient.images.get = mock.MagicMock()
|
|
fakegclient.images.get.side_effect = glance_exc.HTTPNotFound
|
|
mock_osclients.glance.return_value = fakegclient
|
|
|
|
fakenclient = fakes.FakeNovaClient()
|
|
flavor = fakes.FakeFlavor()
|
|
fakenclient.flavors.get = mock.MagicMock(return_value=flavor)
|
|
mock_osclients.nova.return_value = fakenclient
|
|
|
|
validator = validation.image_valid_on_flavor("flavor", "image")
|
|
|
|
test_img_id = "test_image_id"
|
|
|
|
result = validator(clients=mock_osclients,
|
|
flavor={"id": flavor.id},
|
|
image={"id": test_img_id})
|
|
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=flavor.id)
|
|
fakegclient.images.get.assert_called_once_with(image=test_img_id)
|
|
self.assertFalse(result.is_valid)
|
|
self.assertEqual(result.msg, "Image with id 'test_image_id' not found")
|
|
|
|
@mock.patch("rally.osclients.Clients")
|
|
def test_image_valid_on_flavor_flavor_not_exist(self, mock_osclients):
|
|
fakegclient = fakes.FakeGlanceClient()
|
|
mock_osclients.glance.return_value = fakegclient
|
|
|
|
fakenclient = fakes.FakeNovaClient()
|
|
fakenclient.flavors = mock.MagicMock()
|
|
fakenclient.flavors.get.side_effect = nova_exc.NotFound(code=404)
|
|
mock_osclients.nova.return_value = fakenclient
|
|
|
|
validator = validation.image_valid_on_flavor("flavor", "image")
|
|
|
|
test_img_id = "test_image_id"
|
|
test_flavor_id = 101
|
|
|
|
result = validator(clients=mock_osclients,
|
|
flavor={"id": test_flavor_id},
|
|
image={"id": test_img_id})
|
|
|
|
fakenclient.flavors.get.assert_called_once_with(flavor=test_flavor_id)
|
|
|
|
self.assertFalse(result.is_valid)
|
|
self.assertEqual(result.msg, "Flavor with id '101' not found")
|
|
|
|
@mock.patch(TEMPEST + ".Tempest.is_configured")
|
|
@mock.patch(TEMPEST + ".Tempest.is_installed")
|
|
@mock.patch(TEMPEST + ".subprocess")
|
|
def test_tempest_test_name_not_valid(self, mock_sp, mock_install,
|
|
mock_config):
|
|
mock_sp.Popen().communicate.return_value = (
|
|
"tempest.api.fake_test1[gate]\ntempest.api.fate_test2\n",)
|
|
mock_install.return_value = True
|
|
mock_config.return_value = True
|
|
|
|
validator = validation.tempest_tests_exists()
|
|
result = validator(test_name="no_valid_test_name",
|
|
task=mock.MagicMock())
|
|
self.assertFalse(result.is_valid)
|
|
self.assertEqual("One or more tests not found: 'no_valid_test_name'",
|
|
result.msg)
|
|
|
|
@mock.patch(TEMPEST + ".Tempest.is_configured")
|
|
@mock.patch(TEMPEST + ".Tempest.is_installed")
|
|
@mock.patch(TEMPEST + ".subprocess")
|
|
def test_tempest_test_name_valid(self, mock_sp, mock_install, mock_config):
|
|
mock_sp.Popen().communicate.return_value = (
|
|
"tempest.api.compute.fake_test1[gate]\n"
|
|
"tempest.api.image.fake_test2\n",)
|
|
mock_install.return_value = True
|
|
mock_config.return_value = True
|
|
|
|
validator = validation.tempest_tests_exists()
|
|
result = validator(test_name="image.fake_test2", task=mock.MagicMock())
|
|
|
|
self.assertTrue(result.is_valid)
|
|
|
|
@mock.patch(TEMPEST + ".Tempest.is_configured")
|
|
@mock.patch(TEMPEST + ".Tempest.is_installed")
|
|
@mock.patch(TEMPEST + ".subprocess")
|
|
def test_tempest_test_names_one_invalid(self, mock_sp, mock_install,
|
|
mock_config):
|
|
mock_sp.Popen().communicate.return_value = ('\n'.join([
|
|
"tempest.api.fake_test1[gate]",
|
|
"tempest.api.fake_test2",
|
|
"tempest.api.fake_test3[gate,smoke]",
|
|
"tempest.api.fate_test4[fake]"]),)
|
|
mock_install.return_value = True
|
|
mock_config.return_value = True
|
|
|
|
validator = validation.tempest_tests_exists()
|
|
result = validator(test_names=["tempest.api.fake_test2",
|
|
"tempest.api.invalid.test"],
|
|
task=mock.MagicMock())
|
|
|
|
self.assertFalse(result.is_valid)
|
|
self.assertEqual(_("One or more tests not found: '%s'") %
|
|
"tempest.api.invalid.test", result.msg)
|
|
|
|
@mock.patch(TEMPEST + ".Tempest.is_configured")
|
|
@mock.patch(TEMPEST + ".Tempest.is_installed")
|
|
@mock.patch(TEMPEST + ".subprocess")
|
|
def test_tempest_test_names_all_invalid(self, mock_sp, mock_install,
|
|
mock_config):
|
|
mock_sp.Popen().communicate.return_value = ("\n".join([
|
|
"tempest.api.fake_test1[gate]",
|
|
"tempest.api.fake_test2",
|
|
"tempest.api.fake_test3[gate,smoke]",
|
|
"tempest.api.fate_test4[fake]"]),)
|
|
mock_install.return_value = True
|
|
mock_config.return_value = True
|
|
|
|
validator = validation.tempest_tests_exists()
|
|
result = validator(test_names=["tempest.api.invalid.test1",
|
|
"tempest.api.invalid.test2"],
|
|
task=mock.MagicMock())
|
|
|
|
self.assertFalse(result.is_valid)
|
|
self.assertEqual(
|
|
_("One or more tests not found: '%s'") %
|
|
"tempest.api.invalid.test1', 'tempest.api.invalid.test2",
|
|
result.msg)
|
|
|
|
@mock.patch(TEMPEST + ".Tempest.is_configured")
|
|
@mock.patch(TEMPEST + ".Tempest.is_installed")
|
|
@mock.patch(TEMPEST + '.subprocess')
|
|
def test_tempest_test_names_all_valid(self, mock_sp, mock_install,
|
|
mock_config):
|
|
mock_sp.Popen().communicate.return_value = ("\n".join([
|
|
"tempest.api.fake_test1[gate]",
|
|
"tempest.api.fake_test2",
|
|
"tempest.api.fake_test3[gate,smoke]",
|
|
"tempest.api.fate_test4[fake]"]),)
|
|
mock_install.return_value = True
|
|
mock_config.return_value = True
|
|
|
|
validator = validation.tempest_tests_exists()
|
|
result = validator(test_names=["tempest.api.fake_test1",
|
|
"tempest.api.fake_test2"],
|
|
task=mock.MagicMock())
|
|
|
|
self.assertTrue(result.is_valid)
|