diff --git a/.zuul.yaml b/.zuul.yaml index b218376..db85c49 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -10,9 +10,7 @@ check: jobs: - - openstack-tox-pep8: - # TODO: make voting when pep8 job is fixed - voting: false + - openstack-tox-pep8 - rbd-iscsi-client-py36 - openstack-tox-py38 - openstack-tox-py39 @@ -21,9 +19,7 @@ gate: jobs: - - openstack-tox-pep8: - # TODO: make voting when pep8 job is fixed - voting: false + - openstack-tox-pep8 - rbd-iscsi-client-py36 - openstack-tox-py38 - openstack-tox-py39 diff --git a/rbd_iscsi_client/client.py b/rbd_iscsi_client/client.py index 8c718eb..52d021e 100644 --- a/rbd_iscsi_client/client.py +++ b/rbd_iscsi_client/client.py @@ -97,7 +97,7 @@ class RBDISCSIClient(object): {'key': key, 'value': kwargs['data'][key]}) - self._logger.debug("\nREQ: %s\n" % "".join(string_parts)) + self._logger.debug("\nREQ: %s\n", "".join(string_parts)) def _http_log_resp(self, resp, body): if not self.http_log_debug: diff --git a/tox.ini b/tox.ini index d96394b..f33d354 100644 --- a/tox.ini +++ b/tox.ini @@ -117,9 +117,11 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen # reason: no agreement on this being universally # preferable for our code. Disabled to keep checking # tools from getting in our way with regards to this. +# G200 Logging statements should not include the exception +# reason: Many existing cases of this that may be legitimate # show-source = True -ignore = E251,W503,W504 +ignore = E251,W503,W504,G200 enable-extensions=H106,H203,H204,H205 builtins = _ exclude=.venv,.git,.tox,dist,*lib/python*,*egg,build