Replace assertEqual(None, *) with assertIsNone in tests
Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. Change-Id: I8faff65a87adde43373dc2c7874302cfb4d77e1f Partial-bug:#1280522
This commit is contained in:
parent
4f6f92d0dc
commit
7f65a2c104
|
@ -390,7 +390,7 @@ class APIUtilsTestCase(base.BaseTestCase):
|
||||||
('fake_test', const.USER): 'some_other_user',
|
('fake_test', const.USER): 'some_other_user',
|
||||||
('fake_test', const.SHARED_TEST_RUN): None,
|
('fake_test', const.SHARED_TEST_RUN): None,
|
||||||
}.get(args)
|
}.get(args)
|
||||||
self.assertEqual(None, api_utils.get_user_role('fake_test'))
|
self.assertIsNone(api_utils.get_user_role('fake_test'))
|
||||||
self.assertRaises(exc.HTTPError, api_utils.enforce_permissions,
|
self.assertRaises(exc.HTTPError, api_utils.enforce_permissions,
|
||||||
'fake_test', const.ROLE_USER)
|
'fake_test', const.ROLE_USER)
|
||||||
self.assertRaises(exc.HTTPError, api_utils.enforce_permissions,
|
self.assertRaises(exc.HTTPError, api_utils.enforce_permissions,
|
||||||
|
|
|
@ -532,7 +532,7 @@ class DBBackendTestCase(base.BaseTestCase):
|
||||||
# Test no key match.
|
# Test no key match.
|
||||||
filtered.all.return_value = []
|
filtered.all.return_value = []
|
||||||
result = api.get_pubkey(key)
|
result = api.get_pubkey(key)
|
||||||
self.assertEqual(None, result)
|
self.assertIsNone(result)
|
||||||
|
|
||||||
session.query.assert_called_once_with(mock_model)
|
session.query.assert_called_once_with(mock_model)
|
||||||
query.filter_by.assert_called_once_with(md5_hash=khash)
|
query.filter_by.assert_called_once_with(md5_hash=khash)
|
||||||
|
|
Loading…
Reference in New Issue