From 2fca8ee149990a3fcfd94d8de77a30f08382ccf6 Mon Sep 17 00:00:00 2001
From: Gerrit User 16960 <16960@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 18 Jan 2018 19:30:12 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2: Code-Review-1

(2 comments)

The -1 is because I strongly recommend against writing scripts that use the deprecated global priority field.

In terms of translating worklist ordering to the filter, I think the main thing to know would be which worklists are asserting a priority which the runner of the script cares about. In the webclient worklists that the user is subscribed to are noted on the relevant stories to give some idea of priority, perhaps using the subscriptions of the user running the script would help here?

As for filtering by a specific priority, perhaps the script should do some filtering of the result to show something like "tasks that appear in the top 25% of priority worklists they're in"?

The is_bug part is less urgent, but its worth noting that anyone using the webclient will not get the option of setting that field, so it isn't a very reliable source.

FWIW, I agree that these scripts would also be useful in the python-storyboardclient repo.

Patch-set: 2
Reviewer: Gerrit User 16960 <16960@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
---
 59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba | 47 ++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba b/59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba
index 1f48efb..c3ae4b4 100644
--- a/59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba
+++ b/59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba
@@ -22,6 +22,53 @@
       "revId": "59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7f96bb07_98304358",
+        "filename": "sb-filter-stories-by-priority.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 16,
+      "author": {
+        "id": 16960
+      },
+      "writtenOn": "2018-01-18T19:30:12Z",
+      "side": 1,
+      "message": "I\u0027ll also add that global priority is likely to disappear from the API at some point in the future, since it was only meant as a placeholder until we implemented the worklist-based model.",
+      "parentUuid": "7f96bb07_9bbe00d3",
+      "range": {
+        "startLine": 16,
+        "startChar": 0,
+        "endLine": 16,
+        "endChar": 73
+      },
+      "revId": "59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7f96bb07_186af318",
+        "filename": "sb-filter-stories-by-tag.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 44,
+      "author": {
+        "id": 16960
+      },
+      "writtenOn": "2018-01-18T19:30:12Z",
+      "side": 1,
+      "message": "I\u0027d also recommend against using this to determine if a story is a bug or not. It is not exposed in the UI, and likely will never be (and may well be officially deprecated and removed from the API at some point in favour of using tags to describe stories as bugs if needed, which is what we currently recommend).",
+      "range": {
+        "startLine": 44,
+        "startChar": 35,
+        "endLine": 44,
+        "endChar": 41
+      },
+      "revId": "59cf27b91f747cf3fbceeb345e0b4a7ce9d5ffba",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }
\ No newline at end of file