Do not add reviewers when bulk pushing changes
There are multiple problems with it: * the --reviewers options works differently, as it should be added only once and then listed the emails * in case of dummy contacts or not registered contacts the git-review command fails Since we have already a script [1] to add reviewers to *every* open patch, it is easier to run that *after* we finished the bulk uploading of patches. [1] tools/add_reviewers.sh Change-Id: I2942033134adb30db0cd7e955f7bf8aefbbb3c5b
This commit is contained in:
parent
4f103be7f4
commit
20ece035ab
@ -102,20 +102,12 @@ git stash list
|
||||
git branch -va | grep -E "$topic"
|
||||
|
||||
for team in "${!files_by_team_release[@]}" ; do
|
||||
declare -a emails=(
|
||||
$(get-contacts --all "$team"| awk -F': ' '/Email/ {print $2}')
|
||||
)
|
||||
review_args=''
|
||||
for email in ${emails[@]} ; do
|
||||
review_args+=" --reviewers $email"
|
||||
done
|
||||
|
||||
branch_name=${team/ /_}-${topic}
|
||||
git checkout $branch_name
|
||||
git show --stat
|
||||
echo
|
||||
echo 'Push? (Ctrl-C to cancel)'
|
||||
read
|
||||
git review -y -t $topic $review_args
|
||||
git review -y -t $topic
|
||||
done
|
||||
git checkout master
|
||||
|
Loading…
x
Reference in New Issue
Block a user