openstack/releases
Code Issues Proposed changes

Update add_reviewers to add to all open reviews

Browse Source 
This updates the script to not require a specific topic to make it
easier to automate a job that periodically makes sure all open reviews
have had the PTL and liaison added.

Also refactored the adding of teams because bash array handling can be a
bit wonky sometimes and not always append values. This makes sure no
teams are skipped.

This is slightly less optimized for large reviews like the final series
release since it loops through teams based on the deliverable files. As
a slight optimization, it will skip a team if it was the same team as
the last deliverable file. It just might be possible that the same team
will be processed multiple times if their deliverable files are not in
alphabetical order, but there is no harm in that other than taking
slightly longer to complete.

Change-Id: I9a9194ea276aa0120aef21a321f48a93419fb848
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2020-05-09 07:09:23 -05:00
parent 0124abaa2f
commit 27d4f7db98
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tools/add_reviewers.sh
View File

@ -20,15 +20,23 @@
function usage {
echo "Usage: $0 $gerrit_topic"
echo
echo "Example: $0 ussuri-c-w-i"
echo "# Add reviewers to all open reviews"
echo "Example: $0"
echo "# Add reviewers for a specific topic"
echo "Example: $0 ussuri-c-w-i # Adds reviewers for a specific topic"
}
# Validate topic was provided
if [ $# -lt 1 ]; then
if [ $# -gt 1 ]; then
usage
exit 2
fi
topic=""
if [ $# -eq 1 ]; then
topic="+topic:$1"
fi
# We make assumptions that local commands will be available
if [[ -z "$VIRTUAL_ENV" ]]; then
if [[ ! -d .tox/venv ]]; then
@ -55,13 +63,13 @@ GERRIT_PROJECT="openstack/releases"
# Get all open reviews for the given topic
reviews=$(curl -s \
"$GERRIT_URL/changes/?q=status:open+project:$GERRIT_PROJECT+topic:$1" | \
"$GERRIT_URL/changes/?q=status:open+project:$GERRIT_PROJECT${topic}" | \
sed 1d | \
jq --raw-output '.[] | .change_id')
# Loop through each review and find deliverable files
for review in $reviews; do
teams=()
last_team=""
deliverable_files=$(curl -s \
"$GERRIT_URL/changes/?q=$review&o=CURRENT_REVISION&o=CURRENT_FILES" | \
sed 1d | \
@ -71,13 +79,10 @@ for review in $reviews; do
# Extract the owning teams for each deliverable in this patch
for file in $deliverable_files; do
team=$(grep team $file | sed 's/team: //g')
if [[ ! "${teams[@]}" =~ "$team" ]]; then
teams+=($team)
if [[ "$team" == "$last_team" ]]; then
continue
fi
done
# Look up the contacts for each team and add them as reviewers
for team in $teams; do
last_team="$team"
echo "Adding $team reviewers for $review"
declare -a emails=$(
get-contacts --all "$team" | awk -F': ' '/Email/ {print $2}')